Thank you for catching that, Tai. I’m going to keep the vote open a little longer, and please continue to vote for this rc based on this new information. A positive vote for rc4 will mean that this fix will go into 1.4.1. For anyone who has already voted, you can also change your vote if you need to.
> On Jan 14, 2022, at 7:37 PM, Tai Dupree <[email protected]> wrote: > > Actually, I just noticed something. > > Looks like in the RC these two commits were cherry-picked in a reverse > order: > https://github.com/apache/superset/commit/4c00bd4332860912ddecfa9ca02927b514621e3d > https://github.com/apache/superset/commit/ba6d5b97542cbe8cfad5fec1e1e08e1992a0b78e > > on the master branch the order is: > fix: Save properties after applying changes in Dashboard (#17570) … > fix(Dashboard): Copy dashboard with duplicating charts 500 error > > on 1.4.0rc4 the order is > fix(Dashboard): Copy dashboard with duplicating charts 500 error > fix: Save properties after applying changes in Dashboard (#17570) … > > > This is resulting in "fix: Save properties after applying changes in > Dashboard (#17570) …" essentially getting reverted as it was a fix for the > previous commit. The result aside from the 500 error is that position data > is not being carried over during the clone dashboard ("save as" copy) > action. > > >> On Wed, Jan 12, 2022 at 5:57 PM Tai Dupree <[email protected]> wrote: >> >> +1 (binding) >> >> Checked: >> - Dashboard, Chart, Database, Dataset, SQL Lab views load >> - Dashboard view >> - Chart view >> - Dashboard creation >> - Chart creation (time series line) >> >>> On Wed, Jan 12, 2022 at 5:28 PM <[email protected]> wrote: >>> >>> Hello Superset Community, >>> >>> This is a call for the vote to release Apache Superset version 1.4.0. >>> >>> The release candidate: >>> https://dist.apache.org/repos/dist/dev/superset/1.4.0rc4/ >>> >>> Git tag for the release: >>> https://github.com/apache/superset/tree/1.4.0rc4 >>> >>> The Change Log for the release: >>> https://github.com/apache/superset/blob/1.4.0rc4/CHANGELOG.md >>> >>> The Updating instructions for the release: >>> https://github.com/apache/superset/blob/1.4.0rc4/UPDATING.md >>> >>> public keys are available at: >>> >>> https://www.apache.org/dist/superset/KEYS >>> >>> The vote will be open for at least 72 hours or until the necessary number >>> of votes are reached. >>> >>> Please vote accordingly: >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> Thanks, >>> The Apache Superset Team >>> >> >> >> -- >> -Tai Dupree >> > > > -- > -Tai Dupree
