I think all the react crud view tests are mostly covered by js tests and api tests, so deleting those would probably be the path forward. Given that most users run superset with that feature flag enabled, there is little risk to removing that code.
On Thu, Mar 17, 2022 at 11:01 AM Aaron Suddjian <aa...@preset.io> wrote: > Hi folks, the group met today to discuss the ongoing changes for Superset > 2.0. Key discussion points are noted below. > > - Aaron: Removing the ENABLE_REACT_CRUD_VIEWS flag causes lots of tests to > fail - assertions depend on text appearing in crud view html. Will skip > tests for now, and collab with QA to rewrite them. > - Daniel: Celery bump forced us to bump quite a few more packages including > flask, flask-jwt-extended. > - John: Airbnb hasn’t updated flask internally because of some issues. > Daniel & John to sync up. > - Elizabeth: is out next week, can send a rep from team to the meeting > - Evan: A bug was filed with the sqllab backend persistence feature. Fix > should go into 2.0 https://github.com/apache/superset/pull/19225 > - Elizabeth: This is a new bug, not technically tied to the flag itself. > - Grace: Removing omnibar feature as discussed in slack > > Please feel free to join the next working group meeting on March 24th at > 10am PST. The meeting can be found on the Superset Community Calendar. > > -- > Aaron Suddjian, Software Engineer at Preset >
