That sounds great to me, thanks for working on this. In that case I vote -1 (non-binding) on this rc1 and would vote +1 on a subsequent rc where this PR was reverted.
On Tue, Jun 27, 2023, at 7:54 AM, Daniel Gaspar wrote: > Sam, > > Thank you for testing and reporting this issue. > > I think that a path forward would be to revert that PR on 2.1.1 and fixing > Alert & Reports auth issue on master and inclusion on 3.0.0 > > > On Mon, 26 Jun 2023 at 15:26, Sam Firke <[email protected]> wrote: > > > The addition of strong session protection by default < > > https://github.com/apache/superset/pull/24256> meant that I could not log > > into Superset when I switched the image to 2.1.1rc1 – I was stuck in a > > redirect loop from the welcome screen to the login screen. I changed my > > config to SESSION_PROTECTION = “basic” and everything worked okay after > > that. Including alerts & reports, which some users report is broken by the > > default value of “strong”, see the prior link. > > > > Is that enough of a breaking change that the default setting of “strong” > > should happen in 3.0.0? If it’s going into 2.1.1, I think it should be > > highlighted prominently on UPDATING.md < > > https://github.com/apache/superset/blob/master/UPDATING.md>. Right now > > that page does not have a section for 2.1.1, just “Next” which is mostly > > 3.0.0 changes. > > > > Otherwise the release looks good. The bug fixes that pertain to my issues > > work great (like the PivotTable v2 width correction)! > > > > Sam > > > > > > > > On Thu, Jun 22, 2023, at 5:35 AM, Daniel Gaspar wrote: > > > +1 (binding) > > > > > > Daniel Gaspar / Superset PMC > > > > > > > > > On Fri, 16 Jun 2023 at 20:53, Elizabeth Thompson > > > <[email protected]> wrote: > > > > > > > Hello Superset Community, > > > > > > > > This is a call for the vote to release Apache Superset version 2.1.1. > > > > > > > > The release candidate: > > > > https://dist.apache.org/repos/dist/dev/superset/2.1.1rc1/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/superset/tree/2.1.1rc1 > > > > > > > > The Change Log for the release: > > > > https://github.com/apache/superset/blob/2.1.1rc1/CHANGELOG.md > > > > > > > > The Updating instructions for the release: > > > > https://github.com/apache/superset/blob/2.1.1rc1/UPDATING.md > > > > > > > > Public keys are available at: > > > > https://www.apache.org/dist/superset/KEYS > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > number > > > > of votes are reached. > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > Thanks, > > > > The Apache Superset Team > > > > > > > > > > > > > >
