Hi Elizabeth, 

I was not able to find 317970b4400c in 3.0.1rc1. I’m able to find this revision 
on master 
<https://github.com/search?q=repo:apache/superset%20317970b4400c&type=code>. 
It's the added_time_secondary_column_to_.py 
<https://github.com/apache/superset/blob/c81c60c91fbcb09dd63c05f050e18ee09ceebfd6/superset/migrations/versions/2023-09-06_13-18_317970b4400c_added_time_secondary_column_to_.py#L19>
 migration which is not included in 3.0.1rc1. It’s also referenced as the down 
revision of add_on_delete_cascade_for_dashboard_roles.py 
<https://github.com/apache/superset/blob/c81c60c91fbcb09dd63c05f050e18ee09ceebfd6/superset/migrations/versions/2023-09-15_12-58_4b85906e5b91_add_on_delete_cascade_for_dashboard_roles.py#L20>
 but in 3.0.1c1 that migration 
<https://github.com/apache/superset/blob/3.0.1rc1/superset/migrations/versions/2023-09-15_12-58_4b85906e5b91_add_on_delete_cascade_for_dashboard_roles.py>
 uses ec54aca4c8a2 as the down revision. 

Am I missing anything or it’s fine?

> On Oct 4, 2023, at 6:41 PM, Elizabeth Thompson <[email protected]> 
> wrote:
> 
> Michael, just a heads up that it looks like we have a migration in the 
> release that references another migration `317970b4400c` that I didn’t see in 
> the release. 
> 
>> On Oct 4, 2023, at 7:38 AM, Justin Park <[email protected]> wrote:
>> 
>> +1
>> 
>> All patches looks good to me.
>> 
>> On 2023/10/03 17:18:58 "Michael S. Molina" wrote:
>>> Hello Superset Community,
>>> 
>>> This is a call for the vote to release Apache Superset version 3.0.1.
>>> 
>>> The release candidate: 
>>> https://dist.apache.org/repos/dist/dev/superset/3.0.1rc1
>>> 
>>> Git tag for the release:
>>> https://github.com/apache/superset/tree/3.0.1rc1
>>> 
>>> The Change Log for the release:
>>> https://github.com/apache/superset/blob/3.0.1rc1/CHANGELOG.md
>>> 
>>> The Updating instructions for the release:
>>> https://github.com/apache/superset/blob/3.0.1rc1/UPDATING.md
>>> 
>>> Public keys are available at:
>>> https://www.apache.org/dist/superset/KEYS
>>> <https://www.apache.org/dist/superset/KEYS>
>>> The vote will be open for at least 72 hours or until the necessary number
>>> of votes are reached.
>>> 
>>> Please vote accordingly:
>>> 
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>> 
>>> Thanks,
>>> The Apache Superset Team
>>> 
> 

Reply via email to