+1 (binding) On Thu, Nov 16, 2023 at 8:11 PM Ville Brofeldt <ville.v.brofe...@gmail.com> wrote:
> Hi, > > Yes, I'm ok moving ahead as-is, based on the discussion I don't think this > is a show stopper. > > Ville > > On Thu, Nov 16, 2023 at 2:48 PM Elizabeth Thompson > <elizab...@preset.io.invalid> wrote: > > > Thanks Ville, > > It sounds like from the thread that we can move forward with this RC for > > now, and add something in UPDATING for #24826 in a future release? I have > > one more fix that I’d like to get into a release, so I can either do an > RC3 > > and include both of these changes, or do a fast follow for 2.1.3. > > Elizabeth > > > > > On Nov 15, 2023, at 9:45 AM, Ville Brofeldt < > ville.v.brofe...@gmail.com> > > wrote: > > > > > > Hi all, > > > > > > changelog looks good, +1 (binding) from me. However, I'm wondering if > we > > should mention the change from #24826 in `UPDATING.md` as a breaking > change? > > > > > > <24826.png> > > > chore: remove CssTemplate and Annotation access from gamma role by > > lilykuang · Pull Request #24826 · apache/superset > > > github.com > > > < > https://github.com/apache/superset/pull/24826#issuecomment-1812983126 > >chore: > > remove CssTemplate and Annotation access from gamma role by lilykuang · > > Pull Request #24826 · apache/superset < > > https://github.com/apache/superset/pull/24826#issuecomment-1812983126> > > > github.com < > > https://github.com/apache/superset/pull/24826#issuecomment-1812983126> > > > > > > Ville > > > > > >> On Nov 9, 2023, at 6:18 PM, Elizabeth Thompson > > <elizab...@preset.io.INVALID> wrote: > > >> > > >> Hello Superset Community, > > >> > > >> This is a call for the vote to release Apache Superset version 2.1.2. > > >> > > >> The release candidate: > > >> https://dist.apache.org/repos/dist/dev/superset/2.1.2rc2/ > > >> > > >> Git tag for the release: > > >> https://github.com/apache/superset/tree/2.1.2rc2 > > >> > > >> The Change Log for the release: > > >> https://github.com/apache/superset/blob/2.1.2rc2/CHANGELOG.md > > >> > > >> The Updating instructions for the release: > > >> https://github.com/apache/superset/blob/2.1.2rc2/UPDATING.md > > >> > > >> Public keys are available at: > > >> https://www.apache.org/dist/superset/KEYS > > >> > > >> The vote will be open for at least 72 hours or until the necessary > > number > > >> of votes are reached. > > >> > > >> Please vote accordingly: > > >> > > >> [ ] +1 approve > > >> [ ] +0 no opinion > > >> [ ] -1 disapprove with the reason > > >> > > >> Thanks, > > >> The Apache Superset Team > > >> > > > > > > > > -- *Lily Kuang* Senior Software Engineer Preset | https://preset.io