malcolmflint commented on a change in pull request #3375: Improved Datatables
View (and some other minor improvements as well)
URL:
https://github.com/apache/incubator-superset/pull/3375#discussion_r135357724
##########
File path: superset/views/core.py
##########
@@ -61,7 +61,6 @@
USER_MISSING_ERR = __("The user seems to have been deleted")
Review comment:
the reason to go to appbuilder.sm.auth_view.login (line 2231) is so that if
someone were to use OAuth and define their own security manager it doesn't get
stuck in a redirect loop. With default authentication, I believe it works
exactly the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
