rumbin commented on issue #3043: SQL Lab error in exporting .csv when query has 
duplicately named columns
URL: 
https://github.com/apache/incubator-superset/issues/3043#issuecomment-341022004
 
 
   In this case I'd start digging in 
https://github.com/apache/incubator-superset/blob/abfa03474cae49f66caf0d77533bf9b8e040145e/superset/views/core.py#L2181
   
   This is where the query gets executed once more, just for exportring to csv. 
Judging from your observation that the column renaming is fine withiun the 
Result tab in SQLLab, my guess is that the column renaming was forgotten to be 
implemented for the CSV export.
   
   When a Cache backend is configured, the exported results are the very same 
as the ones shown in SQLLab, thus the columns are correctly renamed.
   
   I haven't tried so far finding the code where the deduplication of the 
column names takes place, though...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to