graceguo-supercat closed pull request #3858: [Dashboard bug]Fix cachedDttm prop
type
URL: https://github.com/apache/incubator-superset/pull/3858
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/dashboard/components/GridCell.jsx
b/superset/assets/javascripts/dashboard/components/GridCell.jsx
index 26d8eeb6ea..b0c86ad0c4 100644
--- a/superset/assets/javascripts/dashboard/components/GridCell.jsx
+++ b/superset/assets/javascripts/dashboard/components/GridCell.jsx
@@ -12,7 +12,7 @@ const propTypes = {
datasource: PropTypes.object,
isLoading: PropTypes.bool,
isCached: PropTypes.bool,
- cachedDttm: PropTypes.number,
+ cachedDttm: PropTypes.string,
isExpanded: PropTypes.bool,
widgetHeight: PropTypes.number,
widgetWidth: PropTypes.number,
diff --git a/superset/assets/javascripts/dashboard/components/SliceHeader.jsx
b/superset/assets/javascripts/dashboard/components/SliceHeader.jsx
index 8360017d44..4e8a33537c 100644
--- a/superset/assets/javascripts/dashboard/components/SliceHeader.jsx
+++ b/superset/assets/javascripts/dashboard/components/SliceHeader.jsx
@@ -12,7 +12,7 @@ const propTypes = {
exportCSVUrl: PropTypes.string,
isExpanded: PropTypes.bool,
isCached: PropTypes.bool,
- cachedDttm: PropTypes.number,
+ cachedDttm: PropTypes.string,
formDataExtra: PropTypes.object,
removeSlice: PropTypes.func,
updateSliceName: PropTypes.func,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
