mistercrunch commented on a change in pull request #4030: make string
conversion use utf8
URL:
https://github.com/apache/incubator-superset/pull/4030#discussion_r155842308
##########
File path: superset/viz.py
##########
@@ -1300,9 +1300,9 @@ def get_data(self, df):
for i, v in ys.iteritems():
x = i
if isinstance(x, (tuple, list)):
- x = ', '.join([str(s) for s in x])
+ x = ', '.join([str(s.encode('utf8')) for s in x])
Review comment:
time to upgrade to py3!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
