mistercrunch commented on a change in pull request #4005: [BUGFIX]: Java
scripts max int is 2^53 - 1, longs are bigger
URL:
https://github.com/apache/incubator-superset/pull/4005#discussion_r159708536
##########
File path: superset/viz.py
##########
@@ -421,11 +421,20 @@ def get_data(self, df):
):
del df[m]
- return dict(
+ data = dict(
records=df.to_dict(orient='records'),
columns=list(df.columns),
)
+ for d in data.get('records', dict()):
Review comment:
let's also put this into a `BaseViz.handle_js_int_overflow` method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
