mjdepalma commented on issue #3619: Bottom padding of Separator slice 
(Markdown) too large
URL: 
https://github.com/apache/incubator-superset/issues/3619#issuecomment-355793423
 
 
   In comparing a diff of the HTML provided by @rumbin, two things are apparent:
   (1) The height of the slice_container changes from 65px down to 56.15px.  
(Why?)
   (2) The 20.5 version is using an iframe whose srcdoc appears to contain 
double quotes that are not escaped.  The srcdoc has a double quote before and 
after the html start and end tags, but all the code in between is also using 
double quotes.   Seems like all those should either be changed to single 
quotes, or escaped via & quot ; , right?
   
   @mistercrunch - I like the idea of adding more grain (which would provide 
more flexibility in positioning and better viewability), but it does not seem 
that would address the root of this problem which is that even if there is 
enough space to show the text, it gets clipped.
     
     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to