john-bodley commented on a change in pull request #4291: Fixing json decode
error on druiddatasourcemodelview/api/read
URL:
https://github.com/apache/incubator-superset/pull/4291#discussion_r163974665
##########
File path: superset/connectors/druid/models.py
##########
@@ -91,6 +91,9 @@ class DruidCluster(Model, AuditMixinNullable, ImportMixin):
def __repr__(self):
return self.verbose_name if self.verbose_name else self.cluster_name
+ def __html__(self):
+ return self.verbose_name if self.verbose_name else self.cluster_name
Review comment:
Maybe just call `self.__repr__()` unless you think these method may diverge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
