betodealmeida commented on a change in pull request #4293: Refactoring deckgl
URL:
https://github.com/apache/incubator-superset/pull/4293#discussion_r164532861
##########
File path: superset/assets/visualizations/main.js
##########
@@ -89,14 +86,14 @@ const vizMap = {
[VIZ_TYPES.event_flow]: require('./EventFlow.jsx'),
[VIZ_TYPES.paired_ttest]: require('./paired_ttest.jsx'),
[VIZ_TYPES.partition]: require('./partition.js'),
- [VIZ_TYPES.deck_scatter]: deckglFactory,
- [VIZ_TYPES.deck_screengrid]: deckglFactory,
- [VIZ_TYPES.deck_grid]: deckglFactory,
- [VIZ_TYPES.deck_hex]: deckglFactory,
- [VIZ_TYPES.deck_path]: deckglFactory,
- [VIZ_TYPES.deck_geojson]: deckglFactory,
- [VIZ_TYPES.deck_arc]: deckglFactory,
- [VIZ_TYPES.deck_polygon]: deckglFactory,
+ [VIZ_TYPES.deck_scatter]: require('./deckgl/layers/scatter.jsx').default,
Review comment:
@mistercrunch, is this the right approach? The module is now exporting two
functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
