mistercrunch commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r167758341
##########
File path: superset/viz.py
##########
@@ -307,7 +307,12 @@ def get_df_payload(self, query_obj=None):
cached_dttm = datetime.utcnow().isoformat().split('.')[0]
if cache_key and cache and not self.force:
cache_value = cache.get(cache_key)
- if cache_value:
+ perms_decider = config.get('DATA_PERMS_DECIDER')
+ perms_decider_disapproves = (
Review comment:
`viz.py` doesn't currently handle authorization, I'd rather avoid scattering
the auth logic further across modules. Seems like ideally we'd have most
security-related logic in `security.py` and have `views/base.py` wrap that up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
