timifasubaa commented on a change in pull request #4409: Add permissions decider for delegating access controls. URL: https://github.com/apache/incubator-superset/pull/4409#discussion_r168007018
########## File path: superset/config.py ########## @@ -364,6 +364,24 @@ class CeleryConfig(object): # Interval between consecutive polls when using Hive Engine HIVE_POLL_INTERVAL = 5 + +# System to handle delegated data access. Implement both is_allowed_access() and +# is_eligible_datasource() to delegate access controls. +class PermsDecider: Review comment: But None is falsey and so it will be easy to mix up `access denied` with `I don't know enough to decide for this datasource (from this db)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
