betodealmeida commented on a change in pull request #4480: Add https support
for Druid
URL:
https://github.com/apache/incubator-superset/pull/4480#discussion_r171369588
##########
File path: superset/connectors/druid/models.py
##########
@@ -107,24 +108,29 @@ def data(self):
'backend': 'druid',
}
+ @staticmethod
+ def get_base_url(host, port):
+ if not re.match('http(s)?://', host):
+ host = 'http://' + host
+ return '{0}:{1}'.format(host, port)
+
+ def get_base_coordinator_url(self):
+ base_url = self.get_base_url(
+ self.coordinator_host, self.coordinator_port)
+ return '{base_url}/{self.coordinator_endpoint}'.format(**locals())
+
def get_pydruid_client(self):
cli = PyDruid(
- 'http://{0}:{1}/'.format(self.broker_host, self.broker_port),
+ self.get_base_url(self.broker_host, self.broker_port),
self.broker_endpoint)
return cli
def get_datasources(self):
- endpoint = (
- 'http://{obj.coordinator_host}:{obj.coordinator_port}/'
- '{obj.coordinator_endpoint}/datasources'
- ).format(obj=self)
-
+ endpoint = self.get_base_coordinator_url() + '/datasources'
return json.loads(requests.get(endpoint).text)
def get_druid_version(self):
- endpoint = (
- 'http://{obj.coordinator_host}:{obj.coordinator_port}/status'
- ).format(obj=self)
+ endpoint = self.get_base_coordinator_url() + '/status'
Review comment:
@mistercrunch this is broken, it should use `get_base_url()` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
