hughhhh commented on a change in pull request #4680: Hotkeys in SQL Lab
URL:
https://github.com/apache/incubator-superset/pull/4680#discussion_r177160625
##########
File path: superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
##########
@@ -226,6 +229,32 @@ class SqlEditor extends React.PureComponent {
render() {
const height = this.sqlEditorHeight();
const defaultNorthHeight = this.props.queryEditor.height || 200;
+ const SQLLAB_HOTKEYS = [
Review comment:
nit: Can we put this at the top of the file or even in config file for
adding new hotkeys more easily. I'm like the idea of a having this separate and
we import it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
