john-bodley commented on a change in pull request #4565: [security] Refactor
security code into SupersetSecurityManager
URL:
https://github.com/apache/incubator-superset/pull/4565#discussion_r177261765
##########
File path: superset/data/__init__.py
##########
@@ -71,7 +70,7 @@ def load_energy():
if not tbl:
tbl = TBL(table_name=tbl_name)
tbl.description = "Energy consumption"
- tbl.database = get_or_create_main_db()
+ tbl.database = sm.get_or_create_main_db()
Review comment:
Note this somewhat pre-dates this PR, but I'm not certain that
`get_or_create_main_db` is even security related and thus having the security
manager get or create the `main` database seems somewhat non-intuitive to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
