codecov-io commented on issue #4728: [sql_lab]Disabled run query button if sql query editor is empty URL: https://github.com/apache/incubator-superset/pull/4728#issuecomment-377861570 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=h1) Report > Merging [#4728](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/069d61c53f03608f05a0684572b9a2bb545fd9a6?src=pr&el=desc) will **increase** coverage by `0.15%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4728 +/- ## ========================================== + Coverage 72.22% 72.38% +0.15% ========================================== Files 204 205 +1 Lines 15323 15374 +51 Branches 1180 1182 +2 ========================================== + Hits 11067 11128 +61 + Misses 4253 4243 -10 Partials 3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...scripts/SqlLab/components/RunQueryActionButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLmpzeA==) | `88% <ø> (ø)` | :arrow_up: | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `77.88% <ø> (ø)` | :arrow_up: | | [superset/assets/javascripts/modules/sandbox.js](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvc2FuZGJveC5qcw==) | `93.75% <0%> (-6.25%)` | :arrow_down: | | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <0%> (ø)` | :arrow_up: | | [...cripts/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `0% <0%> (ø)` | :arrow_up: | | [...ts/javascripts/SqlLab/components/TabStatusIcon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1RhYlN0YXR1c0ljb24uanN4) | `94.44% <0%> (ø)` | | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `79.62% <0%> (ø)` | :arrow_up: | | [...javascripts/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `91.74% <0%> (+0.07%)` | :arrow_up: | | [superset/assets/javascripts/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL3JlZHV4VXRpbHMuanM=) | `74.57% <0%> (+0.43%)` | :arrow_up: | | [...pts/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `78.91% <0%> (+0.43%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/4728/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=footer). Last update [069d61c...b55b754](https://codecov.io/gh/apache/incubator-superset/pull/4728?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
