[GitHub] williaster opened a new pull request #4763: [dashboard builder] static layout + toasts

[GitBox]

williaster opened a new pull request #4763: [dashboard builder] static layout + 
toasts
URL: https://github.com/apache/incubator-superset/pull/4763
 
 
   This PR adds several improvements to the dashboard builder
   
   **redux state**
     - changed layout key from `dashboard` => `dashboardLayout` for clarity
     - added `editMode` state + actions/reducers
     - added `messageToasts` state + actions/reducers
   
   **UX improvements**
   - added `<ToastPresenter />` + `<Toast />` components for general messaging
     <img 
src="https://user-images.githubusercontent.com/4496521/38339664-4a2c7fc8-3824-11e8-86cf-2ccdf1d72736.png";
 width="300" />
   - detects and prevents parent overflow on dnd drop, notifies user via toast
     <img 
src="https://user-images.githubusercontent.com/4496521/38339612-f7ec2128-3823-11e8-87d5-e93bbf5bbc8f.gif";
 width="500" />
   - several tweaks to improve drag and drop UX
   
   **UI improvements**
   - propagated `editMode` prop to all `DashboardComponent`s so that they 
render in both editable + static mode (for when the dashboard is in view mode)
   - removed `Spacer` component as it added too much complexity
   - added improved transparent indicator
     <img 
src="https://user-images.githubusercontent.com/4496521/38339528-83778792-3823-11e8-8fee-25207ed9a698.png";
 width="300" />
   - resizable container + header style fixes to ensure that headers are always 
multiples of the grid base unit 
   
   **Cleanup / bug fix**
   - removed grid gutter components, instead added margins between row and 
column contents
   - fixed a bug with resizable containers that resulted in compressed 
component width when too many elements were in a row
   
   @graceguo-supercat @elibrumbaugh
   cc @hughhhh @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services