mistercrunch commented on issue #4756: Improve xAxis ticks, thinner bottom 
margin
URL: 
https://github.com/apache/incubator-superset/pull/4756#issuecomment-378815265
 
 
   I'd also prefer `flat` to staggered as a default, but with the current 
default time formatter the labels overlap in some situation, depending on the 
time grain (some are wider) and on the width (d3.axis fits more or less tick 
density in ways we don't control).
   
   Maybe next PR on this we'd go:
   * new default `auto` format that's shorter than current `Adaptive formatting`
   * use `flat` as new default
   * somehow squeeze `Adaptive formatting` as the tooltip formatter (should be 
possible)
   
   The magic formatting is the part where the devil is in the detail and people 
may not agree on the exact layout. Here's a link to the code we have now:
   
https://github.com/apache/incubator-superset/blob/master/superset/assets/javascripts/modules/dates.js#L15
   
   Oh and we haven't even talked about locales :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to