betodealmeida commented on a change in pull request #4765: [line] fix verbose
names in time shift
URL:
https://github.com/apache/incubator-superset/pull/4765#discussion_r179863054
##########
File path: superset/assets/spec/javascripts/visualizations/nvd3_viz_spec.jsx
##########
@@ -0,0 +1,28 @@
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+
+import { formatLabel } from '../../../visualizations/nvd3_vis';
+
+describe('nvd3 viz', () => {
+ const verboseMap = {
+ foo: 'Foo',
+ bar: 'Bar',
+ };
+ describe('formatLabel', () => {
+ it('is formats simple labels', () => {
Review comment:
Nit, drop the "is"?
`it('formats simple labels', () => {`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
