betodealmeida commented on a change in pull request #4651: [explore] proper filtering of NULLs and '' URL: https://github.com/apache/incubator-superset/pull/4651#discussion_r181228386
########## File path: superset/connectors/sqla/models.py ########## @@ -565,28 +564,20 @@ def get_sqla_query( # sqla where_clause_and = [] having_clause_and = [] for flt in filter: - if not all([flt.get(s) for s in ['col', 'op', 'val']]): + if not all([flt.get(s) for s in ['col', 'op']]): continue col = flt['col'] op = flt['op'] - eq = flt['val'] col_obj = cols.get(col) + eq = self.filter_values_handler( + flt.get('val'), + target_column_is_numeric=col_obj.is_num, + is_list_target=op in ('in', 'not in')) Review comment: Same as above here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services