[GitHub] codecov-io commented on issue #4882: Implement Snowflake engine with supported time grains

[GitBox]

codecov-io commented on issue #4882: Implement Snowflake engine with supported 
time grains
URL: 
https://github.com/apache/incubator-superset/pull/4882#issuecomment-384441539
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr&el=h1)
 Report
   > Merging 
[#4882](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/17ae9ec3a82c93792dd6a6bf0311be4f36e1d063?src=pr&el=desc)
 will **decrease** coverage by `0.09%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4882/graphs/tree.svg?token=KsB0fHcx6l&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #4882     +/-   ##
   =========================================
   - Coverage   76.96%   76.86%   -0.1%     
   =========================================
     Files          44       44             
     Lines        8534     8537      +3     
   =========================================
   - Hits         6568     6562      -6     
   - Misses       1966     1975      +9
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4882/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `51.25% <100%> (-0.64%)` | :arrow_down: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4882/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `73.41% <0%> (-0.82%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr&el=footer).
 Last update 
[17ae9ec...498e7cb](https://codecov.io/gh/apache/incubator-superset/pull/4882?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services