[GitHub] Maxwell2022 commented on issue #978: redirects change https requests to http locations

[GitBox]

Maxwell2022 commented on issue #978: redirects change https requests to http 
locations
URL: 
https://github.com/apache/incubator-superset/issues/978#issuecomment-384835516
 
 
   So I slept over this issue and investigate a bit more about Flask 
application and how these are working behind reverse proxies. It's expecting 
the `X-Forwarded-Proto` header from the reverse proxy. So I just added it to my 
nginx config and all good, not more redirect to http. I'll paste here my nginx 
config if it can help anyone else:
   
   ```
   upstream api {
     server superset-server:8088 max_fails=3;
   }
   
   map $http_upgrade $connection_upgrade {
     default       "upgrade";
     ""            "";
   }
   
   # Force HTTPS
   server {
     listen 80;
     server_name superset.mydomain.com;
     return 301 https://$host$request_uri;
   }
   
   server {
     listen 443 ssl http2;
     server_name                superset.mydomain.com;
   
     ssl_protocols TLSv1 TLSv1.1 TLSv1.2;
     ssl_certificate    
/etc/nginx/letsencrypt/live/superset.mydomain.com/fullchain.pem;
     ssl_certificate_key 
/etc/nginx/letsencrypt/live/superset.mydomain.com/privkey.pem;
     ssl_trusted_certificate 
/etc/nginx/letsencrypt/live/superset.mydomain.com/chain.pem;
   
     access_log /var/log/nginx/superset.access.log main;
     error_log  /var/log/nginx/superset.error.log error;
   
     # Configuration for Lets Encrypt certificate renewal
     include /etc/nginx/snippet/acme-challenge.conf;
   
     location / {
       proxy_pass         http://api;
       proxy_redirect     off;
   
       proxy_set_header   Connection $connection_upgrade;
       proxy_set_header   Upgrade $http_upgrade;
       proxy_set_header   Host $host;
       proxy_set_header   X-Real-IP $remote_addr;
       proxy_set_header   X-Forwarded-For $proxy_add_x_forwarded_for;
       proxy_set_header   X-Forwarded-Proto $scheme;
     }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services