graceguo-supercat commented on a change in pull request #4760: URL shortner for
dashboards
URL:
https://github.com/apache/incubator-superset/pull/4760#discussion_r184816055
##########
File path:
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##########
@@ -157,27 +151,6 @@ class ExploreViewContainer extends React.Component {
}
}
- addHistory({ isReplace = false, title }) {
Review comment:
In airbnb many users didn't realize there is a share linked button. they
still get used to share their work by directly copy-n-paste url from browser. i
guess this change will be dangerous to them :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
