betodealmeida opened a new pull request #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911 The granularity options `week_ending_saturday` ("truncate forward til next Saturday") and `week_start_sunday` ("truncate back til last Sunday") are not working correctly. Currently the granularity dropdown has the same key (`P1W`, one week) for `week`, `week_ending_saturday` and `week_start_sunday`, and only the first one can be selected. I fixed this bug by making the key unique. The ISO 8601 spec supports `time intervals`, so I used `1969-12-28T00:00:00Z/P1W` to represent `week_start_sunday` (since 1969-12-28 was a Sunday), and `P1W/1970-01-03T00:00:00Z` to represent (week_ending_saturday` (since 1970-01-03 was a Saturday). This required modifying the `getPlaySliderParams` function, since it parses the ISO duration in order to get its props. I also added these two granularities to the SQLite backend, in order to test it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
