Vote failed, aborting 0.31.0rc18, starting fresh on 0.32.0rc1 On Wed, Apr 17, 2019 at 1:34 PM Maxime Beauchemin < maximebeauche...@gmail.com> wrote:
> Gotcha. I've been meaning to move these files out of the repository for a > while anyhow, and there's a legitimate question around what the > provenance/license is for these different datasets. > > I wanted to decouple figuring this out with the process of this first > Apache release. > > Max > > On Wed, Apr 17, 2019 at 9:17 AM Alan Gates <alanfga...@gmail.com> wrote: > >> The PR looks fine, except that if Superset doesn't include that data as >> part of the distribution you should remove the CC BY 4 license note from >> LICENSE. >> >> To be clear, I wasn't saying you had to remove those files. IIUC it's >> fine >> to distribute that data under that license. I just wanted to be clear on >> what was covered by that license. Since you can't put headers in the data >> files I'd just put a note in the LICENSE file like ".csv and .csv.gz files >> in this directory are included under CC BY 4" or something. >> >> Alan. >> >> On Tue, Apr 16, 2019 at 11:20 PM Maxime Beauchemin < >> maximebeauche...@gmail.com> wrote: >> >> > @Alan Gates <alanfga...@gmail.com> I'm hoping that I addressed the >> > data-related issue here >> > https://github.com/apache/incubator-superset/pull/7314 >> > >> > On Tue, Apr 16, 2019 at 5:17 PM Maxime Beauchemin < >> > maximebeauche...@gmail.com> wrote: >> > >> >> Given the os-level dependencies and all sorts of other environmental >> >> things, like whether we should use "virutalenv" or not, or the fact >> that we >> >> recommend to have a second clone of the repo (because "git clean" will >> >> remove everything that is not git ignored, like your virtualenv or >> local >> >> configs), I'm tempted to use docker as a reproducible way to generate >> and >> >> test the source release. This would make the process more insulated and >> >> reproducible. Seems reasonable? >> >> >> >> Max >> >> >> >> On Tue, Apr 16, 2019 at 5:01 PM Maxime Beauchemin < >> >> maximebeauche...@gmail.com> wrote: >> >> >> >>> For context David, setup.py says "croniter>=0.3.28" but >> >>> "requirements.txt" has it pinned, though the INSTALL.txt does not >> >>> [currently at least] say to install the pinned deps. >> >>> >> >>> It's debatable whether we should add "pip install -r requirements.txt" >> >>> in INSTALL.txt, but I think given that Superset is an application, I >> think >> >>> we should do it. >> >>> >> >>> Max >> >>> >> >>> On Tue, Apr 16, 2019 at 2:16 PM David Smith <dave.a.sm...@gmail.com> >> >>> wrote: >> >>> >> >>>> True, things can come up. But the croniter issue occurred 21 days ago >> >>>> <https://github.com/taichino/croniter/issues/124> and should not >> have >> >>>> been >> >>>> an issue . We probably don't need to take this thread into a deep >> >>>> discussion about this, but I do think this is a huge gap in how >> branch >> >>>> mechanics are moving code around and how it feeds the release >> >>>> process/chronology. I'll move the discussion to a more appropriate >> >>>> channel. >> >>>> >> >>>> Dave >> >>>> >> >>>> >> >>>> On Tue, Apr 16, 2019 at 2:01 PM Bolke de Bruin <bdbr...@gmail.com> >> >>>> wrote: >> >>>> >> >>>> > I think this one was “mid-flight”. A dependency was deleted from >> the >> >>>> repos >> >>>> > after the release candidate was created. That’s a race condition >> that >> >>>> is >> >>>> > kind of unsolvable ;-). >> >>>> > >> >>>> > Verstuurd vanaf mijn iPad >> >>>> > >> >>>> > > Op 16 apr. 2019 om 20:19 heeft David Smith < >> dave.a.sm...@gmail.com> >> >>>> het >> >>>> > volgende geschreven: >> >>>> > > >> >>>> > > What tests are being performed before releasing? To be blunt: we >> >>>> > shouldn't >> >>>> > > be able to get to a "release" vote without validating that the >> code >> >>>> runs, >> >>>> > > we need to make the process account for robust testing. >> >>>> > > >> >>>> > >> On Tue, Apr 16, 2019 at 11:11 AM Bolke de Bruin < >> bdbr...@gmail.com >> >>>> > >> >>>> > wrote: >> >>>> > >> >> >>>> > >> Have to change to -1, non-binding due to the below mentioned >> >>>> issue. It >> >>>> > >> seems to be a kind of blocker for a first release ;-) >> >>>> > >> >> >>>> > >> I suggest restarting the ([CANCEL] first [VOtE] next )vote with >> a >> >>>> fix >> >>>> > and >> >>>> > >> a bit more boiler plate in the message (binding/non binding, 72h >> >>>> etc). >> >>>> > >> >> >>>> > >> B. >> >>>> > >> >> >>>> > >> Verstuurd vanaf mijn iPad >> >>>> > >> >> >>>> > >>> Op 16 apr. 2019 om 02:27 heeft abhishek sharma < >> >>>> > >> abhioncbr.apa...@gmail.com> het volgende geschreven: >> >>>> > >>> >> >>>> > >>> -1 (since, depenedency croniter==0.3.26 is failing.) >> >>>> > >>> >> >>>> > >>> Thanks. >> >>>> > >>> >> >>>> > >>>> On Mon, Apr 15, 2019 at 3:54 PM Alan Gates < >> alanfga...@gmail.com >> >>>> > >> >>>> > >> wrote: >> >>>> > >>>> >> >>>> > >>>> Per https://www.apache.org/legal/resolved.html#cc-by the CC >> BY >> >>>> 4.0 >> >>>> > >> license >> >>>> > >>>> can only be used on things included in binary form. It >> appears >> >>>> that >> >>>> > it >> >>>> > >> is >> >>>> > >>>> data from the diva-gis.org that is being included under this >> >>>> license, >> >>>> > >>>> which >> >>>> > >>>> I would think meets the requirement. But I don't know how to >> >>>> verify >> >>>> > >> that >> >>>> > >>>> only data files from that source are being included. Is >> there a >> >>>> list >> >>>> > >>>> somewhere of the files included from that source? >> >>>> > >>>> >> >>>> > >>>> Other than that, things look good. License, notice, and >> >>>> disclaimer >> >>>> > >> files >> >>>> > >>>> all look good. All the .py and .sh files have the appropriate >> >>>> Apache >> >>>> > >>>> License header, I didn't find any binaries. >> >>>> > >>>> >> >>>> > >>>> Alan. >> >>>> > >>>> >> >>>> > >>>> On Mon, Apr 15, 2019 at 10:47 AM John Bodley < >> >>>> john.bod...@airbnb.com >> >>>> > >>>> .invalid> >> >>>> > >>>> wrote: >> >>>> > >>>> >> >>>> > >>>>> +1 >> >>>> > >>>>> >> >>>> > >>>>> On Sun, Apr 14, 2019 at 9:18 AM Krist Wongsuphasawat < >> >>>> > >>>>> krist.wo...@gmail.com> >> >>>> > >>>>> wrote: >> >>>> > >>>>> >> >>>> > >>>>>> +1 exciting! >> >>>> > >>>>>> >> >>>> > >>>>>> Best regards, >> >>>> > >>>>>> >> >>>> > >>>>>> Krist >> >>>> > >>>>>> >> >>>> > >>>>>> -- >> >>>> > >>>>>> >> >>>> > >>>>>> Krist Wongsuphasawat >> >>>> > >>>>>> http://kristw.yellowpigz.com >> >>>> > >>>>>> On Apr 14, 2019, 06:24 -0700, Jeff Feng >> >>>> > <jeff.f...@airbnb.com.invalid >> >>>> > >>>>> , >> >>>> > >>>>>> wrote: >> >>>> > >>>>>>> +1 Binding >> >>>> > >>>>>>> >> >>>> > >>>>>>> On Sun, Apr 14, 2019 at 6:20 AM Bolke de Bruin < >> >>>> bdbr...@gmail.com> >> >>>> > >>>>>> wrote: >> >>>> > >>>>>>> >> >>>> > >>>>>>>> +1, non-binding >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> I checked: >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> * SHA512 >> >>>> > >>>>>>>> * Signature of the release, can use some improvement but >> the >> >>>> key >> >>>> > >>>>>> checks out >> >>>> > >>>>>>>> here (https://people.apache.org/keys/committer/): >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> gpg: Signature made Tue Mar 19 07:35:24 2019 CET >> >>>> > >>>>>>>> gpg: using RSA key >> BB990B01715969F648C7A65472DC479A3011B01B >> >>>> > >>>>>>>> gpg: Good signature from "Maxime Beauchemin < >> >>>> > >>>>>> maximebeauche...@gmail.com>" >> >>>> > >>>>>>>> [unknown] >> >>>> > >>>>>>>> gpg: WARNING: This key is not certified with a trusted >> >>>> signature! >> >>>> > >>>>>>>> gpg: There is no indication that the signature belongs to >> the >> >>>> > >>>>>>>> owner. >> >>>> > >>>>>>>> Primary key fingerprint: BB99 0B01 7159 69F6 48C7 A654 >> 72DC >> >>>> 479A >> >>>> > >>>> 3011 >> >>>> > >>>>>> B01B >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> * NOTICE present >> >>>> > >>>>>>>> * LICENSE present >> >>>> > >>>>>>>> * DISCLAIMER present >> >>>> > >>>>>>>> * INSTALL.txt present (did not check build) >> >>>> > >>>>>>>> * ran apache-rat >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> Good luck at the incubator! >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> (O and the vote is open for a minimum of 48h I believe >> :-) ). >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> B. >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> On 14 April 2019 at 00:24:11, Jeff Feng >> >>>> > >>>> (jeff.f...@airbnb.com.invalid >> >>>> > >>>>> ) >> >>>> > >>>>>>>> wrote: >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> ++ this is very exciting. Thank you Max! >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> On Sat, Apr 13, 2019 at 3:19 PM Bolke de Bruin < >> >>>> bdbr...@gmail.com >> >>>> > > >> >>>> > >>>>>> wrote: >> >>>> > >>>>>>>> >> >>>> > >>>>>>>>> Great stuff Max! Good to see this happening! >> >>>> > >>>>>>>>> >> >>>> > >>>>>>>>> - Maybe good to note that only the vote of committers >> >>>> counts as a >> >>>> > >>>>>> binding >> >>>> > >>>>>>>>> vote and that it's good practice to make that clear when >> >>>> voting? >> >>>> > >>>>>>>>> >> >>>> > >>>>>>>>> I'll verify the release tomorrow. >> >>>> > >>>>>>>>> >> >>>> > >>>>>>>>> B. >> >>>> > >>>>>>>>> >> >>>> > >>>>>>>>> Sent from my iPhone >> >>>> > >>>>>>>>> >> >>>> > >>>>>>>>>> On 13 Apr 2019, at 23:56, Maxime Beauchemin < >> >>>> > >>>>>>>> maximebeauche...@gmail.com> >> >>>> > >>>>>>>> >> >>>> > >>>>>>>>> wrote: >> >>>> > >>>>>>>>>> >> >>>> > >>>>>>>>>> Dear all, >> >>>> > >>>>>>>>>> >> >>>> > >>>>>>>>>> The source release 0.31.0 RC18 for Apache Superset is >> >>>> baked and >> >>>> > >>>>>>>> available >> >>>> > >>>>>>>>>> at: >> >>>> > >>>>>>>>>> >> https://dist.apache.org/repos/dist/dev/incubator/superset/ >> >>>> , >> >>>> > >>>>> public >> >>>> > >>>>>>>>>> keys are available >> >>>> > >>>>>>>>>> at >> >>>> > >>>>>> >> >>>> https://dist.apache.org/repos/dist/release/incubator/superset/KEYS >> >>>> > >>>>>>>>>> >> >>>> > >>>>>>>>>> This is the first ASF release candidate of Superset (!)* >> >>>> We're >> >>>> > >>>>>> still >> >>>> > >>>>>>>>>> ironing out our release process, so please bear with us >> and >> >>>> > >>>> help >> >>>> > >>>>>> if you >> >>>> > >>>>>>>>> can*. >> >>>> > >>>>>>>>>> Note that we understand that starting at "RC18" is >> >>>> confusing, >> >>>> > >>>> but >> >>>> > >>>>>>>>>> constitute an outlier as we handoff from the old process >> >>>> to the >> >>>> > >>>>> new >> >>>> > >>>>>>>> one. >> >>>> > >>>>>>>>>> From this point onwards, we intend on using a linear >> >>>> sequence >> >>>> > >>>>> that >> >>>> > >>>>>> maps >> >>>> > >>>>>>>>>> one-to-one with Apache-submitted release candidates. The >> >>>> term >> >>>> > >>>>>> release >> >>>> > >>>>>>>>>> candidate and label RC should be exclusive to the proper >> >>>> > >>>>>>>> Apache-compliant >> >>>> > >>>>>>>>>> release process moving forward. >> >>>> > >>>>>>>>>> >> >>>> > >>>>>>>>>> Also note that I decided to use the label `0.31.0rc18` >> >>>> (pypi >> >>>> > >>>>>> compliant) >> >>>> > >>>>>>>>>> instead of a semver compliant `0.31.0-rc.18` which Pypi >> and >> >>>> > >>>>>> Python's >> >>>> > >>>>>>>>>> PEP-440 won't allow. This being a Python project, we use >> >>>> > >>>> Python's >> >>>> > >>>>>>>>> standards. >> >>>> > >>>>>>>>>> >> >>>> > >>>>>>>>>> As I went along, I documented the process in >> RELEASING.md >> >>>> in >> >>>> > >>>> the >> >>>> > >>>>>> repo, >> >>>> > >>>>>>>>>> latest edits here >> >>>> > >>>>>>>>>> >> >>>> https://github.com/apache/incubator-superset/pull/7296/files >> >>>> > >>>>>>>>>> >> >>>> > >>>>>>>>>> For context, the `0.31` release branch was cut at SHA >> >>>> > >>>> 1fece0d2f, >> >>>> > >>>>>> that >> >>>> > >>>>>>>> was >> >>>> > >>>>>>>>>> merged on master on Jan 22nd. From that common ancestor, >> >>>> the >> >>>> > >>>>>> following >> >>>> > >>>>>>>>> list >> >>>> > >>>>>>>>>> of commit was added as cherry-picks. The SHAs in the >> list >> >>>> > >>>> bellow >> >>>> > >>>>>>>>> reference >> >>>> > >>>>>>>>>> the cherries on the release branch, PR number are >> >>>> available to >> >>>> > >>>>> get >> >>>> > >>>>>> more >> >>>> > >>>>>>>>>> details. >> >>>> > >>>>>>>>>> >> >>>> > >>>>>>>>>> c43d0fd3 [sqlparse] Fixing table name extraction for >> >>>> > >>>> ill-defined >> >>>> > >>>>>> query >> >>>> > >>>>>>>>>> (#7029) >> >>>> > >>>>>>>>>> b64a452a [sql lab] improve table name detection in free >> >>>> form >> >>>> > >>>> SQL >> >>>> > >>>>>>>> (#6793) >> >>>> > >>>>>>>>>> 2357c4aa Adding custom control overrides (#6956) >> >>>> > >>>>>>>>>> 9dd7e84a [sql-parse] Fixing LIMIT exceptions (#6963) >> >>>> > >>>>>>>>>> 5d8dd142 [csv-upload] Fixing message encoding (#6971) >> >>>> > >>>>>>>>>> f454dedd [main] Disable resetting main DB attributes >> >>>> (#6845) >> >>>> > >>>>>>>>>> e967b268 [sqla] Fixing order-by for non-inner-joins >> (#6862) >> >>>> > >>>>>>>>>> a5d9a4e0 Adding template_params to datasource editor for >> >>>> sqla >> >>>> > >>>>>> tables >> >>>> > >>>>>>>>> (#6869) >> >>>> > >>>>>>>>>> 6b895413 [datasource] Ensuring consistent behavior of >> >>>> > >>>> datasource >> >>>> > >>>>>>>>>> editing/saving. (#7037) >> >>>> > >>>>>>>>>> 8ef2789f Adding warning message for sqllab save query >> >>>> (#7028) >> >>>> > >>>>>>>>>> 0ebdb564 fix inaccurate data calculation with adata >> >>>> rolling and >> >>>> > >>>>>>>>>> contribution (#7035) >> >>>> > >>>>>>>>>> b3af6a26 [fix] explore chart from dashboard missed slice >> >>>> title >> >>>> > >>>>>> (#7046) >> >>>> > >>>>>>>>>> c54b067c [db-engine-spec] Aligning Hive/Presto partition >> >>>> logic >> >>>> > >>>>>> (#7007) >> >>>> > >>>>>>>>>> bd65942e Changing time table viz to pass formatTime a >> date >> >>>> > >>>>> (#7020) >> >>>> > >>>>>>>>>> 50accda9 [fix] Cursor jumping when editing chart and >> >>>> dashboard >> >>>> > >>>>>> titles >> >>>> > >>>>>>>>>> (#7038) >> >>>> > >>>>>>>>>> 5ace5769 0.31.0rc17 >> >>>> > >>>>>>>>>> 927a5846 [WIP] fix user specified JSON metadata not >> >>>> updating >> >>>> > >>>>>> dashboard >> >>>> > >>>>>>>> on >> >>>> > >>>>>>>>>> refresh (#7027) >> >>>> > >>>>>>>>>> fafb824d 0.31.0rc16 >> >>>> > >>>>>>>>>> 7b72985e [fix] /superset/slice/id url is too long >> (#6989) >> >>>> > >>>>>>>>>> b497d9e7 fix dashboard links in welcome page (#6756) >> >>>> > >>>>>>>>>> c42afa11 0.31.0rc15 >> >>>> > >>>>>>>>>> 35c55278 Enhancement of query context and object. >> (#6962) >> >>>> > >>>>>>>>>> 1c41020c Split tags migration (#7002) >> >>>> > >>>>>>>>>> ec7a0b22 0.31.0rc14 >> >>>> > >>>>>>>>>> 4655cb4c Remove Cypress from package.json (#6912) >> >>>> > >>>>>>>>>> fb8e3208 0.31.0rc13 >> >>>> > >>>>>>>>>> b4cbe13d VIZ-190 fix (#6958) >> >>>> > >>>>>>>>>> 5b7b22fd 0.31.0rc12 >> >>>> > >>>>>>>>>> 51804229 Fix deck.gl form data (#6953) >> >>>> > >>>>>>>>>> 9939a52d 0.31.0rc11 >> >>>> > >>>>>>>>>> c3db74d9 >> >>>> > >>>> (apache/cherry_c3db74d9021f9e60ef21beeb0847ff9f4b0277fd) >> >>>> > >>>>>> Fix >> >>>> > >>>>>>>>>> rendering regression from the introduction of bignumber >> >>>> (#6937) >> >>>> > >>>>>>>>>> 9940d30a 0.31.0rc10 >> >>>> > >>>>>>>>>> 3df2b8d5 Add a safety check before getting clientHeight >> >>>> (#6923) >> >>>> > >>>>>>>>>> ccb51385 v0.31.0rc9 >> >>>> > >>>>>>>>>> db0235fb Fix database typeahead in SQL Lab (#6917) >> >>>> > >>>>>>>>>> 953d6dc9 Address tooltip's disappearance and stickiness >> >>>> (#6898) >> >>>> > >>>>>>>>>> c0eaa5f6 Fix extra_filters in multi line viz (#6868) >> >>>> > >>>>>>>>>> ebcadc1f >> >>>> > >>>> (apache/cherry_ebcadc1f50994d98bd3dc42e2199b8d0328c061c) >> >>>> > >>>>>> Fix >> >>>> > >>>>>>>>>> tooltip (#6895) >> >>>> > >>>>>>>>>> 5fa5acb5 Add show metadata button back to the explore >> view >> >>>> > >>>>> (#6911) >> >>>> > >>>>>>>>>> ce76560a v0.31.0rc8 >> >>>> > >>>>>>>>>> 8c549b46 Relayout SQL Editor (#6872) >> >>>> > >>>>>>>>>> bfe18963 [cosmetic] TableSelector use <i> instead of >> >>>> <Button> >> >>>> > >>>> for >> >>>> > >>>>>>>> refresh >> >>>> > >>>>>>>>>> (#6783) >> >>>> > >>>>>>>>>> 19b588b5 0.31.0rc7 >> >>>> > >>>>>>>>>> d7e038ea Fixing issue where tooltip gets hidden on >> >>>> dashboard >> >>>> > >>>> for >> >>>> > >>>>>> all >> >>>> > >>>>>>>>> charts >> >>>> > >>>>>>>>>> (#6852) >> >>>> > >>>>>>>>>> 38e0ddac 0.31.0rc6 >> >>>> > >>>>>>>>>> b7d2bd09 Fix line chart overflowing the right side >> (#6829) >> >>>> > >>>>>>>>>> b7e02ab7 [sql lab] fix stuck offline (#6782) >> >>>> > >>>>>>>>>> 8a7c245c 0.31.0rc5 >> >>>> > >>>>>>>>>> f24efa72 Backend only tagging system (#6823) >> >>>> > >>>>>>>>>> 1ddacc42 [wtforms] Using wtforms-json which supports >> None >> >>>> > >>>> (#5445) >> >>>> > >>>>>>>>>> 4f37b9ae 0.31.0rc4 >> >>>> > >>>>>>>>>> 845c7aa9 creating new circular-json safe stringify and >> >>>> > >>>> replacing >> >>>> > >>>>>> one >> >>>> > >>>>>>>> call >> >>>> > >>>>>>>>>> (#6772) >> >>>> > >>>>>>>>>> 8ea805ea Fixing sort issue with area chart and adding >> tests >> >>>> > >>>>> (#6358) >> >>>> > >>>>>>>>>> aff43c74 Allow specifying custom width for logo (#6739) >> >>>> > >>>>>>>>>> 7f865179 Remove test URL (#6740) >> >>>> > >>>>>>>>>> ed0f0ab2 0.31.0rc30.31.0rc30.31.0rc3 >> >>>> > >>>>>>>>>> db81dc50 [fix] Add action for update chart id (#6769) >> >>>> > >>>>>>>>>> 37de92b8 [fix] JS error out when rename a new chart >> (#6752) >> >>>> > >>>>>>>>>> 4d01a02f 0.31.0rc2 >> >>>> > >>>>>>>>>> 0e48e050 Fix sticky tooltips on nvd3 vizzes >> >>>> > >>>>>>>>>> ae95c893 Fix playslider >> >>>> > >>>>>>>>>> 58e3a39f Add iframe and markup legacy plugin (#6741) >> >>>> > >>>>>>>>>> b80b0b90 (apache/0.31) 0.31.0rc1 >> >>>> > >>>>>>>>> >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> -- >> >>>> > >>>>>>>> >> >>>> > >>>>>>>> *Jeff Feng* >> >>>> > >>>>>>>> Product Lead >> >>>> > >>>>>>>> m: (949)-610-5108 >> >>>> > >>>>>>>> twitter: @jtfeng >> >>>> > >>>>>>>> >> >>>> > >>>>>>> >> >>>> > >>>>>>> >> >>>> > >>>>>>> -- >> >>>> > >>>>>>> >> >>>> > >>>>>>> *Jeff Feng* >> >>>> > >>>>>>> Product Lead >> >>>> > >>>>>>> m: (949)-610-5108 >> >>>> > >>>>>>> twitter: @jtfeng >> >>>> > >>>>>> >> >>>> > >>>>> >> >>>> > >>>> >> >>>> > >> >> >>>> > >> >>>> >> >>> >> >
