If it is properly documented in the code and if you add a comment to SYNAPSE-493 so that we can keep track of this, then I'm fine with it.
Andreas On Wed, Mar 4, 2009 at 03:31, Ruwan Linton <ruwan.lin...@gmail.com> wrote: > Andreas, > > I didn't note this earlier. My intention was to switch back to sandesha2 > because the current RM implementation that Synapse is using for the moment > (WSO2 Mercury) is not supported by the WSO2 any more at least in this year > and I wanted to move back to sandesha2. > > If I describe the history of the RM implementation switching we couldn't get > Sandesha2 to work with NIO HTTP transport after the 1.0 release of synapse > and that is why we moved to the Mercury implementation and now I don't want > synapse to depend on that because the project is not live at this moment. > > So I suggest that we use this as a work around till we get this fixed in > Sandesha2.... I have tested all the scenarios which might be affected by > this change and if there is any issue please do let me know. I will add a > TODO documentation in to this piece of code as well. > > (We need to get RM to work with Sandesha2 for the 1.3 release) > > Thanks, > Ruwan > > On Wed, Mar 4, 2009 at 4:18 AM, Andreas Veithen <andreas.veit...@gmail.com> > wrote: >> >> Ruwan, >> >> This change was proposed in SYNAPSE-493, but there the conclusion was >> that this change would be in contradiction with the available >> documentation in Axis2 and that it is more likely an issue in >> Sandesha2. >> >> Andreas >> >> On Tue, Mar 3, 2009 at 22:37, <ru...@apache.org> wrote: >> > Author: ruwan >> > Date: Tue Mar 3 21:37:47 2009 >> > New Revision: 749766 >> > >> > URL: http://svn.apache.org/viewvc?rev=749766&view=rev >> > Log: >> > set the status to WAITING for fixing some RM scenarios, I have tested >> > with all dual channel invocations and it seems to work fine >> > >> > Modified: >> > >> > synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreRequestResponseTransport.java >> > >> > Modified: >> > synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreRequestResponseTransport.java >> > URL: >> > http://svn.apache.org/viewvc/synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreRequestResponseTransport.java?rev=749766&r1=749765&r2=749766&view=diff >> > >> > ============================================================================== >> > --- >> > synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreRequestResponseTransport.java >> > (original) >> > +++ >> > synapse/trunk/java/modules/transports/src/main/java/org/apache/synapse/transport/nhttp/HttpCoreRequestResponseTransport.java >> > Tue Mar 3 21:37:47 2009 >> > @@ -39,7 +39,7 @@ >> > public class HttpCoreRequestResponseTransport implements >> > RequestResponseTransport { >> > >> > private static final Log log = >> > LogFactory.getLog(HttpCoreRequestResponseTransport.class); >> > - private RequestResponseTransportStatus status = >> > RequestResponseTransportStatus.INITIAL; >> > + private RequestResponseTransportStatus status = >> > RequestResponseTransportStatus.WAITING; >> > private MessageContext msgContext = null; >> > private boolean responseWritten = false; >> > >> > >> > >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org >> For additional commands, e-mail: dev-h...@synapse.apache.org >> > > > > -- > Ruwan Linton > http://wso2.org - "Oxygenating the Web Services Platform" > http://ruwansblog.blogspot.com/ > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org
