[
https://issues.apache.org/jira/browse/SYNAPSE-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680085#action_12680085
]
Eric Hubert commented on SYNAPSE-514:
-------------------------------------
Hi Ruwan,
the HessianMessageFormatter is not affected from that change as there is not
differentiation between "normal" hessian responses and "fault" hessian
responses, which is perfectly fine. The only differentation made is for the
case that a SOAP fault (most likely created by the FaultMediator) shall be
"formatted" as a hessian fault. For this case the HessianMessageFormatter
currently constructs a Hessian fault message.
Anyway the HessianMessageFormatter could also get some minor code cleanups and
a unit test. I will do so and submit another patch soon.
> Enhance HessianMessageBuilder with fault detection
> --------------------------------------------------
>
> Key: SYNAPSE-514
> URL: https://issues.apache.org/jira/browse/SYNAPSE-514
> Project: Synapse
> Issue Type: Improvement
> Components: Extension Mediators
> Affects Versions: 1.2
> Reporter: Eric Hubert
> Assignee: Ruwan Linton
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HessianMessageBuilder.patch, restresources.zip
>
>
> Currently there is no way to detect Hessian faults in the mediation. For most
> other message formats this has already been implemented. Once a fault is
> detected a property indicating the fault is stored inside the Axis message
> context.
> The attached patch add the same behavior for binary Hessian messages. It
> extends the existing HessianMessageBuilder. Additionally the patch includes
> unit tests to test the added functionality as well as the existing one. So
> far there were no unit tests.
> The unit test need some binary hessian messages as test resources. I included
> them in the patch to ease the review but do think it might make more sense to
> put them in the svn repo individually. So I'll attach those files separately
> as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org
