[ 
https://issues.apache.org/jira/browse/SYNAPSE-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693601#action_12693601
 ] 

Asankha C. Perera commented on SYNAPSE-526:
-------------------------------------------

Hi Eric

I typically use "svn diff > file.patch" since that handles full paths to files 
and new files well.

The changes looks good.. I would also like the default config values/samples to 
be included into the synapse.properties so that its easier for users to look 
for it and configure it. It would also be nice to have this started by default 
and an INFO level log to state the JMX URL like to connect to, even if nothing 
is explicitly configured. For the port, you could start on a suitable default 
and find something which is available

thanks
asankha

> Add server connector to make use of existing MBeans
> ---------------------------------------------------
>
>                 Key: SYNAPSE-526
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-526
>             Project: Synapse
>          Issue Type: Improvement
>    Affects Versions: 1.2
>            Reporter: Eric Hubert
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: JmxAdapter.patch
>
>
> Hi,
> currently Synapse does not create a JMX server connector to enable the user 
> to make use of the existing MBeans via JConsole or any other JMX-compliant 
> management solution. The attached patch introduces a small JMXAdapter class 
> to create an RMI registry using a specified JNDI port in synapse.properties 
> (synapse.jmx.jndiPort). Only if this port is specified it will create the 
> registry and start the server connector. If the user additionally specifies a 
> fixed RMI port in synapse.properties (synapse.jmx.rmiPort) instead of using a 
> dynamic RMI port Synapse will use the specified port thus allowing a 
> firewalled setup (you have to open both ports in your firewall).
> The Javadoc of the class explains the connect syntax:
> service:jmx:rmi:///jndi/rmi://<hostname>:<jndiPort>/synapse or 
> service:jmx:rmi://<hostname>:<rmiPort>/jndi/rmi://<hostname>:<jndiPort>/synapse
> This patch shall just demonstrate the basic idea. I'm of course willing to 
> contribute further work on this (including documentation). The best place in 
> the startup and shutdown phase of Synapse should be discussed. I'm going to 
> start a separate discussion on the order of actions in the Synapse startup 
> phase anyway.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to