+1, please add the debug. Ruwan
On Wed, Jul 28, 2010 at 11:05 PM, Hiranya Jayathilaka <hiranya...@gmail.com>wrote: > > > On Wed, Jul 28, 2010 at 11:00 PM, Hiranya Jayathilaka < > hiranya...@gmail.com> wrote: > >> >> >> On Wed, Jul 28, 2010 at 10:39 PM, Ruwan Linton <ruwan.lin...@gmail.com>wrote: >> >>> Hiranya, >>> >>> On Wed, Jul 28, 2010 at 5:23 PM, <hira...@apache.org> wrote: >>> >>>> Author: hiranya >>>> Date: Wed Jul 28 11:53:25 2010 >>>> New Revision: 980029 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=980029&view=rev >>>> Log: >>>> Removing some redundant log messages in the artifact deployers. If a >>>> particular artifact is not available in the SynapseConfiguration by the >>>> time >>>> the undeploy event is fired, that means the artifact has already been >>>> undeployed by some other means. >>> >>> >>> What sort of an other means, if you cannot give a concrete normal case >>> where this could happen, >>> >> >> Sorry for not stating any actual use cases. There could be many.... >> >> >>> isn't it an error?? >>> >> >> Not exactly. This code has been written under the assumption that the only >> way a hot deployed artifact can get undeployed is by deleting the file in >> the file system. But in an application, which programmatically manipulates >> the SynapseConfiguration, items can get undeployed without first deleting >> the file. In such situations this is the expected behavior and it is not >> something to be logged as a warning or an error. >> >> >>> Well it has to be warn actually since there is no harm. >>> >> >> I wouldn't log this at a level higher than debug. Will add them in a >> future commit. >> > > Also the debug message should be something like "Artifact abc has already > been undeployed from the system".... > > >> >> Thanks, >> Hiranya >> >> >>> >>> Thanks, >>> Ruwan >>> >>> >>>> No need to log this incident as an error. >>>> >>>> >>>> >>>> Modified: >>>> >>>> >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EndpointDeployer.java >>>> >>>> >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EventSourceDeployer.java >>>> >>>> >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/LocalEntryDeployer.java >>>> >>>> >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/ProxyServiceDeployer.java >>>> >>>> >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/SequenceDeployer.java >>>> >>>> >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/TaskDeployer.java >>>> >>>> Modified: >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EndpointDeployer.java >>>> URL: >>>> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EndpointDeployer.java?rev=980029&r1=980028&r2=980029&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EndpointDeployer.java >>>> (original) >>>> +++ >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EndpointDeployer.java >>>> Wed Jul 28 11:53:25 2010 >>>> @@ -146,8 +146,6 @@ public class EndpointDeployer extends Ab >>>> + artifactName + " : Completed"); >>>> } >>>> log.info("Endpoint named '" + ep.getName() + "' has >>>> been undeployed"); >>>> - } else { >>>> - log.error("Couldn't find the endpoint named : " + >>>> artifactName); >>>> } >>>> } catch (Exception e) { >>>> handleSynapseArtifactDeploymentError("Endpoint Undeployement >>>> of endpoint named : " >>>> >>>> Modified: >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EventSourceDeployer.java >>>> URL: >>>> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EventSourceDeployer.java?rev=980029&r1=980028&r2=980029&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EventSourceDeployer.java >>>> (original) >>>> +++ >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/EventSourceDeployer.java >>>> Wed Jul 28 11:53:25 2010 >>>> @@ -139,8 +139,6 @@ public class EventSourceDeployer extends >>>> + artifactName + " : Completed"); >>>> } >>>> log.info("EventSource named '" + es.getName() + "' has >>>> been undeployed"); >>>> - } else { >>>> - log.error("Couldn't find the EventSource named : " + >>>> artifactName); >>>> } >>>> } catch (Exception e) { >>>> handleSynapseArtifactDeploymentError("EventSource >>>> Undeployement of EventSource named : " >>>> >>>> Modified: >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/LocalEntryDeployer.java >>>> URL: >>>> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/LocalEntryDeployer.java?rev=980029&r1=980028&r2=980029&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/LocalEntryDeployer.java >>>> (original) >>>> +++ >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/LocalEntryDeployer.java >>>> Wed Jul 28 11:53:25 2010 >>>> @@ -131,8 +131,6 @@ public class LocalEntryDeployer extends >>>> + artifactName + " : Completed"); >>>> } >>>> log.info("LocalEntry named '" + e.getKey() + "' has >>>> been undeployed"); >>>> - } else { >>>> - log.error("Couldn't find the LocalEntry named : " + >>>> artifactName); >>>> } >>>> } catch (Exception e) { >>>> handleSynapseArtifactDeploymentError( >>>> >>>> Modified: >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/ProxyServiceDeployer.java >>>> URL: >>>> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/ProxyServiceDeployer.java?rev=980029&r1=980028&r2=980029&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/ProxyServiceDeployer.java >>>> (original) >>>> +++ >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/ProxyServiceDeployer.java >>>> Wed Jul 28 11:53:25 2010 >>>> @@ -156,8 +156,6 @@ public class ProxyServiceDeployer extend >>>> + artifactName + " : Completed"); >>>> } >>>> log.info("ProxyService named '" + proxy.getName() + "' >>>> has been undeployed"); >>>> - } else { >>>> - log.error("Couldn't find the ProxyService named : " + >>>> artifactName); >>>> } >>>> } catch (Exception e) { >>>> handleSynapseArtifactDeploymentError( >>>> >>>> Modified: >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/SequenceDeployer.java >>>> URL: >>>> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/SequenceDeployer.java?rev=980029&r1=980028&r2=980029&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/SequenceDeployer.java >>>> (original) >>>> +++ >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/SequenceDeployer.java >>>> Wed Jul 28 11:53:25 2010 >>>> @@ -162,8 +162,6 @@ public class SequenceDeployer extends Ab >>>> + artifactName + " : Completed"); >>>> } >>>> log.info("Sequence named '" + seq.getName() + "' has >>>> been undeployed"); >>>> - } else { >>>> - log.error("Couldn't find the sequence named : " + >>>> artifactName); >>>> } >>>> } catch (Exception e) { >>>> handleSynapseArtifactDeploymentError( >>>> >>>> Modified: >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/TaskDeployer.java >>>> URL: >>>> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/TaskDeployer.java?rev=980029&r1=980028&r2=980029&view=diff >>>> >>>> ============================================================================== >>>> --- >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/TaskDeployer.java >>>> (original) >>>> +++ >>>> synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/deployers/TaskDeployer.java >>>> Wed Jul 28 11:53:25 2010 >>>> @@ -135,8 +135,6 @@ public class TaskDeployer extends Abstra >>>> + artifactName + " : Completed"); >>>> } >>>> log.info("StartupTask named '" + st.getName() + "' has >>>> been undeployed"); >>>> - } else { >>>> - log.error("Couldn't find the StartupTask named : " + >>>> artifactName); >>>> } >>>> } catch (Exception e) { >>>> handleSynapseArtifactDeploymentError( >>>> >>>> >>>> >>> >>> >>> -- >>> Ruwan Linton >>> Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb >>> WSO2 Inc.; http://wso2.org >>> >>> Lean . Enterprise . Middleware >>> >>> phone: +1 408 754 7388 ext 51789 >>> email: ru...@wso2.com; cell: +94 77 341 3097 >>> blog: http://blog.ruwan.org >>> linkedin: http://www.linkedin.com/in/ruwanlinton >>> google: http://www.google.com/profiles/ruwan.linton >>> tweet: http://twitter.com/ruwanlinton >>> >> >> >> >> -- >> Hiranya Jayathilaka >> Senior Software Engineer; >> >> WSO2 Inc.; http://wso2.org >> E-mail: hira...@wso2.com; Mobile: +94 77 633 3491 >> Blog: http://techfeast-hiranya.blogspot.com >> > > > > -- > Hiranya Jayathilaka > Senior Software Engineer; > WSO2 Inc.; http://wso2.org > E-mail: hira...@wso2.com; Mobile: +94 77 633 3491 > Blog: http://techfeast-hiranya.blogspot.com > -- Ruwan Linton Software Architect & Product Manager, WSO2 ESB; http://wso2.org/esb WSO2 Inc.; http://wso2.org Lean . Enterprise . Middleware phone: +1 408 754 7388 ext 51789 email: ru...@wso2.com; cell: +94 77 341 3097 blog: http://blog.ruwan.org linkedin: http://www.linkedin.com/in/ruwanlinton google: http://www.google.com/profiles/ruwan.linton tweet: http://twitter.com/ruwanlinton
