Thanks for pointing out the issues.. - Changed to for loop iterating logic - Removed the redundant return statement - Ran findbugs, but i don't see any warnings..
Updated the patch is attached to jira.. Thanks -Ratha On 19 April 2012 20:16, Afkham Azeez <[email protected]> wrote: > Can you please run FindBugs & cleanup the code & resubmit the patch? > Please don't use the iterator in while loops but use a for loop, and also I > noticed a redundant return statement. Please review the code and resubmit. > > > On Thu, Apr 19, 2012 at 1:42 AM, vijayaratha vijayasingam < > [email protected]> wrote: > >> I have added the implementation of remaining part as a patch here[1] . >> Please go through and let me know if there are any issues/concerns >> >> [1]https://issues.apache.org/jira/browse/SYNAPSE-864 >> >> Thanks >> -Ratha >> >> >> On 2 April 2012 12:04, Afkham Azeez <[email protected]> wrote: >> >>> Sorry, I didn't have the time to look into this. >>> >>> >>> On Mon, Apr 2, 2012 at 10:22 AM, vijayaratha vijayasingam < >>> [email protected]> wrote: >>> >>>> Hi azeez; >>>> Were you able to check this? >>>> Thanks >>>> -Ratha >>>> >>>> >>>> On 19 March 2012 14:35, vijayaratha vijayasingam <[email protected] >>>> > wrote: >>>> >>>>> If we define a ClassEndpoint type, this problem can be resolved.. >>>>> -Ratha >>>>> >>>>> >>>>> On 19 March 2012 14:18, Hiranya Jayathilaka <[email protected]>wrote: >>>>> >>>>>> >>>>>> >>>>>> On Mon, Mar 19, 2012 at 2:14 PM, Afkham Azeez <[email protected]>wrote: >>>>>> >>>>>>> Yes, I didn't implement the serialization part. However, custom >>>>>>> endpoint definition is working fine. The tricky thing is, the >>>>>>> serialization >>>>>>> logic does an "instanceof" check on the endpoint type, and then tries to >>>>>>> serialize it. So, serialization does not work for any endpoint we define >>>>>>> using class endpoint. We have to think of a proper way to implement >>>>>>> this. >>>>>> >>>>>> >>>>>> Just trying to understand the problem here. Why should this be any >>>>>> different from how the class mediators are serialized? The serializer >>>>>> just >>>>>> need to know the name of the implementing class right? >>>>>> >>>>>> Thanks, >>>>>> Hiranya >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, Mar 19, 2012 at 1:57 PM, vijayaratha vijayasingam < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi azeez, >>>>>>>> I tried the recent implementation of supporting the custom >>>>>>>> endpoints, but facing an issue while saving the custom endpoints..No >>>>>>>> Serializer for this type endpoint? >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Ratha >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Hiranya Jayathilaka >>>>>> Associate Technical Lead; >>>>>> WSO2 Inc.; http://wso2.org >>>>>> E-mail: [email protected]; Mobile: +94 77 633 3491 >>>>>> Blog: http://techfeast-hiranya.blogspot.com >>>>>> >>>>> >>>>> >>>> >>> >>> >>> -- >>> *Afkham Azeez* >>> Director of Architecture; WSO2, Inc.; http://wso2.com, >>> *Member; Apache Software Foundation; >>> **http://www.apache.org/*<http://www.apache.org/> >>> * >>> * >>> *email: **[email protected]* <[email protected]>* cell: +94 77 3320919 >>> blog: **http://blog.afkham.org* <http://blog.afkham.org>* >>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> >>> * >>> linked-in: **http://lk.linkedin.com/in/afkhamazeez* >>> * >>> * >>> *Lean . Enterprise . Middleware* >>> * >>> * >>> >>> >> > > > -- > *Afkham Azeez* > Director of Architecture; WSO2, Inc.; http://wso2.com, > *Member; Apache Software Foundation; > **http://www.apache.org/*<http://www.apache.org/> > * > * > *email: **[email protected]* <[email protected]>* cell: +94 77 3320919 > blog: **http://blog.afkham.org* <http://blog.afkham.org>* > twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> > * > linked-in: **http://lk.linkedin.com/in/afkhamazeez* > * > * > *Lean . Enterprise . Middleware* > * > * > >
