According to a recent discussion on the [email protected] list, including binary artifacts in source distributions is in violation of ASF policies. Here the case is a bit different because the ZIP (which contains 3rd party JARs) is only used in test cases, but I think it is a very bad practice anyway to include such things into the source tree. If you need a ZIP during unit tests, then the build should assemble it before running these tests.
Andreas On Wed, Apr 18, 2012 at 17:23, <[email protected]> wrote: > Author: uswick > Date: Wed Apr 18 15:23:07 2012 > New Revision: 1327543 > > URL: http://svn.apache.org/viewvc?rev=1327543&view=rev > Log: > committing patch for https://issues.apache.org/jira/browse/SYNAPSE-862 > > Added: > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/ > > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/LibImportTest.java > > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/util/ > > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/util/LibDeployerUtilsTest.java > synapse/trunk/java/modules/core/src/test/resources/synapse-libraries/ > > synapse/trunk/java/modules/core/src/test/resources/synapse-libraries/SynapseTestLibrary.zip > (with props) > > Added: > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/LibImportTest.java > URL: > http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/LibImportTest.java?rev=1327543&view=auto > ============================================================================== > --- > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/LibImportTest.java > (added) > +++ > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/LibImportTest.java > Wed Apr 18 15:23:07 2012 > @@ -0,0 +1,101 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one > + * or more contributor license agreements. See the NOTICE file > + * distributed with this work for additional information > + * regarding copyright ownership. The ASF licenses this file > + * to you under the Apache License, Version 2.0 (the > + * "License"); you may not use this file except in compliance > + * with the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, > + * software distributed under the License is distributed on an > + * * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > + * KIND, either express or implied. See the License for the > + * specific language governing permissions and limitations > + * under the License. > + */ > +package org.apache.synapse.libraries; > + > +import junit.framework.TestCase; > +import org.apache.synapse.libraries.imports.SynapseImport; > +import org.apache.synapse.libraries.model.Library; > +import org.apache.synapse.libraries.util.LibDeployerUtils; > +import org.apache.synapse.libraries.util.LibDeployerUtilsTest; > + > +/** > + * Created by IntelliJ IDEA. > + * User: charitha > + * Date: 4/16/12 > + * Time: 4:38 PM > + * To change this template use File | Settings | File Templates. > + */ > +public class LibImportTest extends TestCase { > + > + > + public void testValidImports() { > + Library library = > LibDeployerUtils.createSynapseLibrary(LibDeployerUtilsTest.class.getResource("/synapse-libraries/SynapseTestLibrary.zip").getPath()); > + SynapseImport validSynImport = new SynapseImport(); > + validSynImport.setLibName("SynapseLinkedinLib"); > + validSynImport.setLibPackage("org.apache.synapse.linkedin"); > + if (validSynImport != null) { > + LibDeployerUtils.loadLibArtifacts(validSynImport, library); > + } > + assertEquals("SynapseLinkedinLib", > library.getQName().getLocalPart()); > + assertEquals("org.apache.synapse.linkedin", library.getPackage()); > + assertEquals("synapse library for Linkedin", > library.getDescription()); > + > assertNotNull(library.getArtifact("org.apache.synapse.linkedin.post_status")); > + > assertNotNull(library.getArtifact("org.apache.synapse.linkedin.show_headline")); > + > assertNotNull(library.getArtifact("org.apache.synapse.linkedin.send_message")); > + > assertNotNull(library.getArtifact("org.apache.synapse.linkedin.register_user")); > + library.unLoadLibrary(); > + assertEquals("SynapseLinkedinLib", > library.getQName().getLocalPart()); > + assertEquals("org.apache.synapse.linkedin", library.getPackage()); > + assertEquals("synapse library for Linkedin", > library.getDescription()); > + > assertNull(library.getArtifact("org.apache.synapse.linkedin.post_status")); > + > assertNull(library.getArtifact("org.apache.synapse.linkedin.show_headline")); > + > assertNull(library.getArtifact("org.apache.synapse.linkedin.send_message")); > + > assertNull(library.getArtifact("org.apache.synapse.linkedin.register_user")); > + } > + > + public void testInValidImportsCaseOne() { > + Library library = > LibDeployerUtils.createSynapseLibrary(LibDeployerUtilsTest.class.getResource("/synapse-libraries/SynapseTestLibrary.zip").getPath()); > + SynapseImport invalidSynImport = new SynapseImport(); > + invalidSynImport.setLibName("testSynapseLinkedinLib"); > + invalidSynImport.setLibPackage("org.apache.synapse.linkedin"); > + if (invalidSynImport != null) { > + LibDeployerUtils.loadLibArtifacts(invalidSynImport, library); > + } > + assertEquals("SynapseLinkedinLib", > library.getQName().getLocalPart()); > + assertEquals("org.apache.synapse.linkedin", library.getPackage()); > + > assertNull(library.getArtifact("org.apache.synapse.linkedin.post_status")); > + } > + > + public void testInValidImportsCaseTwo() { > + Library library = > LibDeployerUtils.createSynapseLibrary(LibDeployerUtilsTest.class.getResource("/synapse-libraries/SynapseTestLibrary.zip").getPath()); > + SynapseImport invalidSynImport = new SynapseImport(); > + invalidSynImport.setLibName("SynapseLinkedinLib"); > + invalidSynImport.setLibPackage("test.org.apache.synapse.linkedin"); > + if (invalidSynImport != null) { > + LibDeployerUtils.loadLibArtifacts(invalidSynImport, library); > + } > + assertEquals("SynapseLinkedinLib", > library.getQName().getLocalPart()); > + assertEquals("org.apache.synapse.linkedin", library.getPackage()); > + > assertNull(library.getArtifact("org.apache.synapse.linkedin.post_status")); > + } > + > + public void testInValidImportsCaseThree() { > + Library library = > LibDeployerUtils.createSynapseLibrary(LibDeployerUtilsTest.class.getResource("/synapse-libraries/SynapseTestLibrary.zip").getPath()); > + SynapseImport invalidSynImport = new SynapseImport(); > + invalidSynImport.setLibName("testSynapseLinkedinLib"); > + invalidSynImport.setLibPackage("test.org.apache.synapse.linkedin"); > + if (invalidSynImport != null) { > + LibDeployerUtils.loadLibArtifacts(invalidSynImport, library); > + } > + assertEquals("SynapseLinkedinLib", > library.getQName().getLocalPart()); > + assertEquals("org.apache.synapse.linkedin", library.getPackage()); > + > assertNull(library.getArtifact("org.apache.synapse.linkedin.post_status")); > + } > + > +} > > Added: > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/util/LibDeployerUtilsTest.java > URL: > http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/util/LibDeployerUtilsTest.java?rev=1327543&view=auto > ============================================================================== > --- > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/util/LibDeployerUtilsTest.java > (added) > +++ > synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/libraries/util/LibDeployerUtilsTest.java > Wed Apr 18 15:23:07 2012 > @@ -0,0 +1,52 @@ > +/* > + * Licensed to the Apache Software Foundation (ASF) under one > + * or more contributor license agreements. See the NOTICE file > + * distributed with this work for additional information > + * regarding copyright ownership. The ASF licenses this file > + * to you under the Apache License, Version 2.0 (the > + * "License"); you may not use this file except in compliance > + * with the License. You may obtain a copy of the License at > + * > + * http://www.apache.org/licenses/LICENSE-2.0 > + * > + * Unless required by applicable law or agreed to in writing, > + * software distributed under the License is distributed on an > + * * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > + * KIND, either express or implied. See the License for the > + * specific language governing permissions and limitations > + * under the License. > + */ > +package org.apache.synapse.libraries.util; > + > +import junit.framework.TestCase; > +import org.apache.synapse.libraries.model.Library; > + > +import javax.xml.namespace.QName; > +import java.net.URL; > + > +/** > + * Created by IntelliJ IDEA. > + * User: charitha > + * Date: 3/30/12 > + * Time: 4:54 PM > + * To change this template use File | Settings | File Templates. > + */ > +public class LibDeployerUtilsTest extends TestCase { > + > + String path; > + > + public void setUp() { > + URL resource = > LibDeployerUtilsTest.class.getResource("/synapse-libraries/SynapseTestLibrary.zip"); > + path = resource.getPath(); > + } > + > + public void testCreateSynapseLibrary() { > + Library library = LibDeployerUtils.createSynapseLibrary(path); > + assertNotNull(library); > + assertEquals(new > QName("org.apache.synapse.linkedin","SynapseLinkedinLib"), > library.getQName()); > + assertEquals("SynapseLinkedinLib", > library.getQName().getLocalPart()); > + assertEquals("org.apache.synapse.linkedin", library.getPackage()); > + assertEquals("synapse library for Linkedin", > library.getDescription()); > + } > + > +} > > Added: > synapse/trunk/java/modules/core/src/test/resources/synapse-libraries/SynapseTestLibrary.zip > URL: > http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/test/resources/synapse-libraries/SynapseTestLibrary.zip?rev=1327543&view=auto > ============================================================================== > Binary file - no diff available. > > Propchange: > synapse/trunk/java/modules/core/src/test/resources/synapse-libraries/SynapseTestLibrary.zip > ------------------------------------------------------------------------------ > svn:mime-type = application/octet-stream > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
