[
https://issues.apache.org/jira/browse/SYNAPSE-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udayanga Wickramasinghe updated SYNAPSE-928:
--------------------------------------------
Attachment: synapse_sample_903.xml
synapse_sample_900.xml
synapse_sample_901.xml
synapse_sample_902.xml
synapse_sample_904.xml
synapse_sample_905.xml
synapse_artifact_versionig_reviewed_gsoc13.patch
Hi,
Thank you Thilini for your contribution. I have reviewed your patch and overall
it is good. However i have made some reviews, following are the major changes
i did.
a) some code are duplicated specially in XXXVersionedDispatcher classes , so I
corrected them . Note : make sure always to reduce redundancy in code. It makes
clean code, also less redundancy ==> less effort for maintaining your code
b) only axis2.xml of Synapse engine needs to refer the in-flow handler of
VersionedURI dispatcher for proxy services. no need to insert that in
client/server axis2.xml
c) MultiXML Configuration builder is not handled properly. You have made proper
changes to SynapseConfigurationBuilder that is good but also needs to reflect
that in MultiXML Builder (this is where artifacts are read from respective
artifact folders). I have added them now !
d) Correcting Main Sequence dispatching - if for a particular URI any of the
versioned main sequences cannot be found then we should fall back to default
versioned 'main'. Since otherwise this request would not be served, this can be
undesirable. for example synapse can act as a router for all incoming requests
and this cannot be achieved with current strategy.
e) Corrected Test cases
However there is one critical problem in message store versioning. sample 905
you have provided is not working please do correct that. Also how do you
process messages from versioned stores ? for example would following work ?
<messageProcessor
class="org.apache.synapse.message.processors.sampler.SamplingProcessor"
name="SamplingProcessor" version="2.0.0" messageStore="MyStore3/1.0.0">
I assume you have already fixed above issue.
By the way I have noticed that we missed Local entry versioning which is
actually a major part in Synapse. However considering the scale of the project
and significant amount of work you have contributed, i dont think you will need
to complete that for Gsoc deadline. However i hope that you can contribute
that along with a proper set of solid test cases/samples/documetaion as
discussed after the deadline. Please submit the rest of the patch ( fault
handler versioning/ documentation ) you are currently working on as well.
Regards
Udayanga
> [GSoC] Versioning of Synapse config artifacts
> ---------------------------------------------
>
> Key: SYNAPSE-928
> URL: https://issues.apache.org/jira/browse/SYNAPSE-928
> Project: Synapse
> Issue Type: Improvement
> Reporter: Kasun Indrasiri
> Assignee: Udayanga Wickramasinghe
> Priority: Critical
> Labels: gsoc2013, mentor
> Attachments: sequence_endpoint_versioning_reviewed.patch,
> Sequence_Versioning_Patch.patch,
> Sequence_Versioning_Reviewd_SYNAPSE-928.patch,
> synapse_artifact_versionig_reviewed_gsoc13.patch, synapse_sample_900.xml,
> synapse_sample_901.xml, synapse_sample_902.xml, synapse_sample_903.xml,
> synapse_sample_904.xml, synapse_sample_905.xml
>
>
> Currently non of the synapse artifacts fully support versioning mechanism.
> This feature is to support a new versioning strategy for all such artifacts.
> Sequence, Proxy Service, API, Endpoints
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
