Hi Andreas,

It looks like following two tests are failing as
testSubscriptionMessageBuilderScenarioFive is getting executed before them.

testSubscriptionMessageBuilderScenarioFour(org.apache.synapse.eventing.builders.MessageBuilderTest):
testSubscriptionMessageBuilderScenarioThree(org.apache.synapse.eventing.builders.MessageBuilderTest):

Then cause is static variables in SubscriptionMessageBuilder class.

private static String errorSubCode = null;
private static String errorReason = null;
private static String errorCode = null;

I think we need a proper fix rather than enforcing the test order.

Thanks.


On Sat, Feb 20, 2016 at 9:11 PM, <[email protected]> wrote:

> Author: veithen
> Date: Sat Feb 20 15:41:12 2016
> New Revision: 1731416
>
> URL: http://svn.apache.org/viewvc?rev=1731416&view=rev
> Log:
> Attempt to fix flaky test case.
>
> Modified:
>
> synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/eventing/builders/MessageBuilderTest.java
>
> Modified:
> synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/eventing/builders/MessageBuilderTest.java
> URL:
> http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/eventing/builders/MessageBuilderTest.java?rev=1731416&r1=1731415&r2=1731416&view=diff
>
> ==============================================================================
> ---
> synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/eventing/builders/MessageBuilderTest.java
> (original)
> +++
> synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/eventing/builders/MessageBuilderTest.java
> Sat Feb 20 15:41:12 2016
> @@ -21,6 +21,8 @@ package org.apache.synapse.eventing.buil
>
>  import junit.framework.TestCase;
>  import org.apache.synapse.mediators.TestUtils;
> +import org.junit.FixMethodOrder;
> +import org.junit.runners.MethodSorters;
>  import org.apache.synapse.eventing.SynapseSubscription;
>  import org.apache.axis2.context.MessageContext;
>  import org.apache.axis2.addressing.EndpointReference;
> @@ -32,9 +34,10 @@ import javax.xml.namespace.QName;
>  import java.util.Calendar;
>  import java.util.Date;
>
> +@FixMethodOrder(MethodSorters.NAME_ASCENDING)
>  public class MessageBuilderTest extends TestCase {
>
> -    public void testSubscriptionMessageBuilderScenarioOne() {
> +    public void testSubscriptionMessageBuilderScenario1() {
>          String subManUrl = "
> http://synapse.test.com/eventing/subscriptions";;
>          String addressUrl = "http://www.other.example.com/OnStormWarning
> ";
>          String filterDialect = "http://www.example.org/topicFilter";;
> @@ -86,7 +89,7 @@ public class MessageBuilderTest extends
>          }
>      }
>
> -    public void testSubscriptionMessageBuilderScenarioTwo() {
> +    public void testSubscriptionMessageBuilderScenario2() {
>          String addressUrl = "
> http://synapse.test.com/eventing/subscriptions";;
>
>          String message = "<wse:Unsubscribe xmlns:wse=\"
> http://schemas.xmlsoap.org/ws/2004/08/eventing\"/>";
> @@ -109,7 +112,7 @@ public class MessageBuilderTest extends
>          }
>      }
>
> -    public void testSubscriptionMessageBuilderScenarioThree() {
> +    public void testSubscriptionMessageBuilderScenario3() {
>          String addressUrl = "
> http://synapse.test.com/eventing/subscriptions";;
>          Date date = new Date(System.currentTimeMillis() + 3600000);
>          Calendar cal = Calendar.getInstance();
> @@ -140,7 +143,7 @@ public class MessageBuilderTest extends
>          }
>      }
>
> -    public void testSubscriptionMessageBuilderScenarioFour() {
> +    public void testSubscriptionMessageBuilderScenario4() {
>          String addressUrl = "
> http://synapse.test.com/eventing/subscriptions";;
>
>          String message =
> @@ -164,7 +167,7 @@ public class MessageBuilderTest extends
>          }
>      }
>
> -    public void testSubscriptionMessageBuilderScenarioFive() {
> +    public void testSubscriptionMessageBuilderScenario5() {
>          String addressUrl = "
> http://synapse.test.com/eventing/subscriptions";;
>
>          String message =
>
>
>


-- 
*Isuru Udana*
Associate Technical Lead




*; WSO2 Inc.; http://wso2.com <http://wso2.com>email: [email protected]
<[email protected]> blog: http://mytecheye.blogspot.com/
<http://mytecheye.blogspot.com/>*

Reply via email to