[ 
https://issues.apache.org/jira/browse/SYNAPSE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15305514#comment-15305514
 ] 

Isuru Udana Loku Narangoda edited comment on SYNAPSE-1021 at 5/28/16 7:20 PM:
------------------------------------------------------------------------------

Hi Buddhima,

Thank you for providing the patch with test cases.
I have done some major refactoring to and committed at r1745911.
Please have a look at the changes.
I changed the of default scope to soap as to me default doesn't make sense. 
Please let me know if you think otherwise. 

I am keeping the issue open until you provide some feedback on the changes.

Thanks.


was (Author: isudana):
Hi Buddhima,

Thank you for providing the patch with test cases.
I have done some major refactoring to and committed at r1745911.
Please have a look at the changes.
I changed the of default scope to soap soap as to me default doesn't make 
sense. Please let me know if you think otherwise. 

I am keeping the issue open until you provide some feedback on the changes.

Thanks.

> Improve Header Mediator to add/remove transport headers
> -------------------------------------------------------
>
>                 Key: SYNAPSE-1021
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-1021
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Buddhima Wijeweera
>            Assignee: Isuru Udana Loku Narangoda
>              Labels: features
>         Attachments: header_mediator_tran-scope_improvement.diff
>
>
> Currently header mediator is used for set or remove headers from the current 
> SOAP infoset.
> With this, Header mediator is improved to set or remove headers from 
> transport as well. Though this can be achieved also with property mediator, 
> using header mediator will make configuration more readable and clearer.
> Syntax:
> {noformat}
> <header name="qname" (value="literal" | expression="xpath") [action="set"] 
> [scope=default|transport]/>
> {noformat}
> Example:
> {noformat}
> <header name="Accept" value="text/html" scope="transport"/>
> {noformat}
> Please note that this will not affect already existing configurations as, 
> null/default scope still mean altering SOAP headers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org
For additional commands, e-mail: dev-h...@synapse.apache.org

Reply via email to