[ https://issues.apache.org/jira/browse/SYNAPSE-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vanjikumaran Sivajothy updated SYNAPSE-1061: -------------------------------------------- Attachment: SYNAPSE-1061.diff > WeightedRRLCAlgorithm Unwanted condition > ----------------------------------------- > > Key: SYNAPSE-1061 > URL: https://issues.apache.org/jira/browse/SYNAPSE-1061 > Project: Synapse > Issue Type: Bug > Reporter: Vanjikumaran Sivajothy > Assignee: Hiranya Jayathilaka > Attachments: SYNAPSE-1061.diff > > > was going through with WeightedRRLCAlgorithm and noticed that useless > condition used in reCalcuateWeight(). Why do we need that condition over > there and it is already known that totalConnections is not a zero. > {code} > public void reCalcuateWeight() { > if (totalConnections > 0) { > double weightRatio = (double) fixedWeight / totalWeight; > double connectionRatio; > if (totalConnections != 0) { //useless condition...?? > connectionRatio = (double) currentConnectionCount / > totalConnections; > } else { > connectionRatio = 0; > } > double diff = weightRatio - connectionRatio; > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@synapse.apache.org For additional commands, e-mail: dev-h...@synapse.apache.org