Hi Shafreen, I have rollbacked the windows-latest as it failed[1]. Can you check on that?
[1] https://github.com/apache/synapse/runs/631388207 On Wed, Apr 29, 2020 at 7:02 AM shafreen anfar <anfar.shafr...@gmail.com> wrote: > Hi All, > > At the moment the build that runs for each PR only runs on ubuntu and Java > 8. With this PR [1] I have added windows and mac to the build along with > Java 7. > > [1] https://github.com/apache/synapse/pull/44 > > On Wed, Mar 11, 2020 at 6:21 PM shafreen anfar <anfar.shafr...@gmail.com> > wrote: > >> Hi Isuru, >> >> On Wed, Mar 11, 2020 at 6:40 AM Isuru Udana <isud...@gmail.com> wrote: >> >>> Hi Shafreen, >>> >>> I have merged the pull request. >>> I still can't see the workflow get attached to the existing PRs, does it >>> only work for the new PRs? >>> >> >> It doesn't work existing PRs unless we edit it. But for all the new PRs >> the workflow will get attached. >> >> >>> >>> >>> >>> On Tue, Mar 10, 2020 at 10:46 PM Vanjikumaran Sivajothy < >>> vanjikuma...@gmail.com> wrote: >>> >>>> Shafreen, >>>> +1 for the Github Workflow. >>>> >>>> adding fortnightly build action plan also allow, us to monitor these >>>> certificate issue. >>>> Will you be able to look into that too? >>>> >>>> On Tue, Mar 10, 2020 at 10:10 AM Isuru Udana <isud...@gmail.com> wrote: >>>> >>>>> +1 >>>>> Let me first check the current build failure before merging this. >>>>> >>>>> On Tue, Mar 10, 2020 at 7:01 PM Madhawa Kasun Gunasekara < >>>>> madhaw...@gmail.com> wrote: >>>>> >>>>>> +1 >>>>>> This is great. >>>>>> >>>>>> >>>>>> On Tue, Mar 10, 2020 at 2:18 PM shafreen anfar < >>>>>> anfar.shafr...@gmail.com> wrote: >>>>>> >>>>>>> Hi All, >>>>>>> >>>>>>> At the moment, when there is a new PR, we always have to build >>>>>>> locally to make sure the new PR doesn't introduce any regression issues. >>>>>>> However, with Github Actions we can automate this effort with zero >>>>>>> cost. I >>>>>>> have written a Github workflow to automatically build new PRs to check >>>>>>> its >>>>>>> validity. Current Github workflow only runs on latest-ubuntu with Java >>>>>>> 8. >>>>>>> However, we can further improve it as we move forward. Please, find the >>>>>>> PR >>>>>>> for this improvement in link [1]. Once merged it will look like in the >>>>>>> below image. >>>>>>> >>>>>>> [image: image.png] >>>>>>> >>>>>>> [1] https://github.com/apache/synapse/pull/25 >>>>>>> >>>>>>> Thanks >>>>>>> Shafreen >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> *Isuru Udana* >>>>> Associate Director/Architect >>>>> >>>>> >>>>> >>>>> *; WSO2 Inc.; http://wso2.com <http://wso2.com>email: >>>>> isud...@gmail.com <isud...@gmail.com> * >>>>> >>>>> >>>>> >>>> >>>> -- >>>> Best Regards, >>>> Vanji >>>> >>> >>> >>> -- >>> *Isuru Udana* >>> Associate Director/Architect >>> >>> >>> >>> *; WSO2 Inc.; http://wso2.com <http://wso2.com>email: isud...@gmail.com >>> <isud...@gmail.com> * >>> >>> >>> -- Best Regards, Vanji
