Thanks. Will update the PR accordingly. On Mon, Nov 2, 2020 at 7:53 AM Isuru Udana <isud...@gmail.com> wrote:
> Thanks Shafreen. I reviewed it and suggested a few minor modifications. > > On Sun, Nov 1, 2020 at 11:42 AM Shafreen <anfar.shafr...@gmail.com> wrote: > >> Hi All, >> >> Please find the below PR for this improvement. >> >> https://github.com/apache/synapse/pull/50 >> >> I will send another PR updating the doc once this is merged. >> >> On Sat, Oct 17, 2020 at 9:27 AM Vanjikumaran Sivajothy < >> vanjikuma...@gmail.com> wrote: >> >>> I agree with your suggestion; it is much better clean design approach. >>> >>> >>> On Fri, Oct 16, 2020 at 8:34 PM Shafreen <anfar.shafr...@gmail.com> >>> wrote: >>> >>>> Hi All, >>>> >>>> Any opinion on this? >>>> >>>> On Sun, Oct 11, 2020 at 11:45 AM Shafreen <anfar.shafr...@gmail.com> >>>> wrote: >>>> >>>>> Hi All, >>>>> >>>>> Each Message Forwarding Processor must have a target endpoint. At the >>>>> moment we configure this target endpoint by adding a property in the >>>>> in-sequence of proxy service as follows. >>>>> >>>>> <property name="target.endpoint" value="StockQuoteServiceEp" /> >>>>> >>>>> IMO, this way of associating target-endpoint with Message Forwarding >>>>> Processor is not only error prone but also less readable. Therefore, I >>>>> think we can improve configuring target endpoint by making it at an >>>>> attribute of the Message Forwarding Processor as follows, >>>>> >>>>> <messageProcessor class= >>>>> "org.apache.synapse.message.processors.forward.ScheduledMessageForwardingProcessor" >>>>> name="ScheduledProcessor" messageStore="MyStore" >>>>> *targetEndpoint="StockQuoteServiceEp"*> <parameter name="interval"> >>>>> 10000</parameter> <parameter name="max.deliver.attempts">3</parameter> >>>>> <parameter name="max.deliver.drop">true</parameter> </messageProcessor >>>>> > >>>>> >>>>> WDYT ? >>>>> >>>> -- >>> Sent from Gmail Mobile >>> >> > > -- > *Isuru Udana* > Associate Director/Architect > > > > *; WSO2 Inc.; http://wso2.com <http://wso2.com>email: isud...@gmail.com > <isud...@gmail.com> * > > >
