Hi all, since locating similar unit tests in the *SendMediatorSerializationTest* class, I thought it is best to include the new unit test also in the same one without adding a brand new class. > > I'm currently trying to write the unit tests for similar functionality > I've written for the WSDLEndpointFactory. > Accordingly, I added my initial unit tests to the *SendMediatorSerializationTest* class and sent it in with my original PR. The new changes can be found here <https://github.com/apache/synapse/pull/55/commits/736bd24e342c66ab8bf1d8d65dd0f8f20d9c54c7> and here <https://github.com/apache/synapse/pull/55/commits/40f9b7e6192c70a05fce26a74f65ddd3b85f23fe> .
Kind regards On Thu, Apr 7, 2022 at 6:59 PM Nuwan Jayawardene <nsga...@gmail.com> wrote: > Hi all, > >> shall I attempt to write a unit test to fill the gap if it's required? >> > I was working on the above when I came across the > *testWSDLEndpointSerialization* > <https://github.com/apache/synapse/blob/0b3dec37a47f602036bf1c417fc8a32605a95fe9/modules/core/src/test/java/org/apache/synapse/config/xml/SendMediatorSerializationTest.java#L85> > method existing in the *SendMediatorSerializationTest* class. > To my eyes, it appears very much like a unit test for WSDL endpoints and I > just wanted to verify before proceeding with developing the test as it > would be rendered redundant otherwise. > > Kind regards > > On Wed, Mar 23, 2022 at 8:54 PM Isuru Udana <isud...@gmail.com> wrote: > >> >> On Wed, Mar 23, 2022 at 9:05 AM Nuwan Jayawardene <nsga...@gmail.com> >> wrote: >> >>> Noted Isuru, >>> shall I attempt to write a unit test to fill the gap if it's required? >>> >> +1 >> >>> >>> Kind regards >>> >>> >>> >>> >>> On Tue, Mar 22, 2022 at 11:42 PM Isuru Udana <isud...@gmail.com> wrote: >>> >>>> Hi Nuwan, >>>> >>>> It looks like there is no unit test exists for the WSDLEndpointFactory. >>>> >>>> Thanks. >>>> >>>> On Tue, Mar 22, 2022 at 9:44 AM Nuwan Jayawardene <nsga...@gmail.com> >>>> wrote: >>>> >>>>> Hi all, >>>>> I recently created a PR adding new functionality to the >>>>> AddressEndpointFactory >>>>> <https://github.com/apache/synapse/pull/55/commits/a85a439e10a75d75a925e33414c2e75c5f07e1f5> >>>>> class and associated unit test in the AddressEndpointSerializationTest >>>>> <https://github.com/apache/synapse/pull/55/commits/6869b869892d0d26022aaddff0acc069a3d5b2bb> >>>>> class. >>>>> >>>>> I'm currently trying to write the unit tests for similar functionality >>>>> I've written for the WSDLEndpointFactory. However, I've been having some >>>>> trouble finding out the associated unit tests for the methods in >>>>> WSDLEndpointFactory. >>>>> >>>>> I tried debugging via mvn test -Dmaven.surefire.debug to find out if >>>>> any unit test will hit my debug point but had no luck. >>>>> >>>>> Would appreciate some feedback on this. >>>>> Kind regards >>>>> -- >>>>> *Nuwan Jayawardene* >>>>> Assistant Lecturer, Informatics Institute of Technology (IIT). >>>>> Research Assistant, University of Moratuwa >>>>> >>>>> https://www.linkedin.com/m/in/nuwanjaya >>>>> >>>>> >>>>> >>>> >>>> -- >>>> *Isuru Udana* >>>> Associate Director / Architect >>>> WSO2 Inc.; http://wso2.com >>>> Member, Apache Software Foundation; http://www.apache.org >>>> >>>> *email: isud...@gmail.com <isud...@gmail.com>* cell: +94 77 3791887 >>>> >>>> >>> >>> -- >>> *Nuwan Jayawardene* >>> Assistant Lecturer, Informatics Institute of Technology (IIT). >>> Research Assistant, University of Moratuwa >>> >>> https://www.linkedin.com/m/in/nuwanjaya >>> >>> >> >> -- >> *Isuru Udana* >> Associate Director / Architect >> WSO2 Inc.; http://wso2.com >> Member, Apache Software Foundation; http://www.apache.org >> >> *email: isud...@gmail.com <isud...@gmail.com>* cell: +94 77 3791887 >> >> > > -- > *Nuwan Jayawardene* > Assistant Lecturer, Informatics Institute of Technology (IIT). > Research Assistant, University of Moratuwa > > https://www.linkedin.com/m/in/nuwanjaya > > -- *Nuwan Jayawardene* Assistant Lecturer, Informatics Institute of Technology (IIT). Research Assistant, University of Moratuwa https://www.linkedin.com/m/in/nuwanjaya
