[ 
https://issues.apache.org/jira/browse/SYNCOPE-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542092#comment-13542092
 ] 

Jan Bernhardt edited comment on SYNCOPE-259 at 1/2/13 11:52 AM:
----------------------------------------------------------------

OK, I tested the provided patch. Looks good for most parts (thanks to 
Christian). Here is what I additionally did:

1. Moved Version from client pom.xml file to parent pom file, since all version 
numbers are managed in syncopes (root) parent pom file.

2. Added Deprecated Annotations to Service methods that should be moved or 
replaced once CXF migration is complete

3. Added Search Operations to Interface & implemented these new methods in 
UserServiceProxy

4. Updated SearchTestITCase to also use UserServiceProxy

I was able to run: "mvn clean install" without any exceptions.
                
      was (Author: jan4talend):
    OK, I tested the provided patch. Looks good for most parts (thank you 
Christian). Here is what I additionally did:

1. Moved Version from client pom.xml file to paretn pom file, since all version 
numbers are managed in syncopes (root) parent pom file.

2. Added Deprecated Annotations to Service methods that should be moved or 
replaced once CXF migration is complete

3. Added Search Operations to Interface & implemented these new methods in 
UserServiceProxy

4. Updated SearchTestITCase to also use UserServiceProxy

I was able to run: "mvn clean install" without any exceptions.
                  
> Create transitional Service interfaces and switch tests and console to use 
> them
> -------------------------------------------------------------------------------
>
>                 Key: SYNCOPE-259
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-259
>             Project: Syncope
>          Issue Type: Improvement
>          Components: client, console, core
>    Affects Versions: 1.1.0
>            Reporter: Christian Schneider
>            Assignee: Jan Bernhardt
>             Fix For: 1.1.0
>
>         Attachments: SYNCOPE-259.patch
>
>
> As preparation of the change to use CXF instead of Spring MVC REST 
> controllers this issue is to introduce transitional service interfaces (like 
> as UserService).
> The UserService interface should later be used in the core to provide the 
> UserController and on the console to access the service remotely.
> To make the transition easier the idea is to already introduce the interface 
> upfront and change all tests and the console to use it. Before the switch the 
> implementation of the interface will simply use the restTemplate under the 
> covers.
> This to be applied similarly to all Spring MVC REST controllers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to