[
https://issues.apache.org/jira/browse/SYNCOPE-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Shakirin updated SYNCOPE-259:
------------------------------------
Attachment: ResourceService.patch
Added patch for ResourceService.
Essential changes in JAX-RS annotations:
1) update. Operation is mapped to HTTP put instead post (as far as I can see
update is idempotent); resourceName is added to URL - it allows also rename
resource
2) delete. Operation is mapped to HTTP delete instead get.
3) check. Operation is mapped to HTTP get as far as it is save and idempotent
Two operations check() and getPropagationActionsClasses() seems not to be
directly related to resources.
- check() validates connection instance and for me it is candidate for
ConnInstanceService. Actually test for check() operation located in
ConnInstancetestITCase.
- getPropagationActionsClasses() returns list of class names for
PROPAGATION_ACTIONS from classloader. Not sure that this operation should be in
ResourceService.
At the moment I leave both operations in ResourceService.
> Create transitional Service interfaces and switch tests and console to use
> them
> -------------------------------------------------------------------------------
>
> Key: SYNCOPE-259
> URL: https://issues.apache.org/jira/browse/SYNCOPE-259
> Project: Syncope
> Issue Type: Improvement
> Components: client, console, core
> Affects Versions: 1.1.0
> Reporter: Christian Schneider
> Assignee: Jan Bernhardt
> Fix For: 1.1.0
>
> Attachments: ResourceService.patch, SYNCOPE-259.patch
>
>
> As preparation of the change to use CXF instead of Spring MVC REST
> controllers this issue is to introduce transitional service interfaces (like
> as UserService).
> The UserService interface should later be used in the core to provide the
> UserController and on the console to access the service remotely.
> To make the transition easier the idea is to already introduce the interface
> upfront and change all tests and the console to use it. Before the switch the
> implementation of the interface will simply use the restTemplate under the
> covers.
> This to be applied similarly to all Spring MVC REST controllers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
