[ 
https://issues.apache.org/jira/browse/SYNCOPE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated SYNCOPE-241:
----------------------------------------

    Attachment: SYNCOPE-241-4.patch

I have finished another step (SYNCOPE-241-4.patch).

In this step I did the following:
- revert the split of policy into policy and impl as in fact the references to 
other parts of core were only for suspending users. So I added an interface 
UserSuspender and implemented it in .workflow.WorkflowUserSuspender
- move ContentLoader to persistence.dao.impl and refactored it a bit
- Move the workflow related parts out of SpringContextInitializer into 
WorkflowSetup and ActivityDetector so it does not have too many responsibilities
- adjust component-scan in persistenceContext.xml and syncopeContext.xml so 
they reflect the layers
- created testpersistence.xml which contains everything needed by the 
persistence tests and switch the persistence tests to use only this instead of 
all the other contexts
- Created TestDBInitializer which loads the db content without doing the rest 
of the SpringContextInitializer tasks

So I hope that after this patch I can start to really move the persistence 
classes to a new persistence module

                
> Move persistence and persistence impl into separate modules
> -----------------------------------------------------------
>
>                 Key: SYNCOPE-241
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-241
>             Project: Syncope
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.0.3-incubating
>            Reporter: Christian Schneider
>             Fix For: 1.1.0
>
>         Attachments: SYNCOPE-241-2.patch, SYNCOPE-241-3.patch, 
> SYNCOPE-241-4.patch, SYNCOPE-241.patch
>
>
> The core module currently contains many parts of syncope. This makes it 
> bigger and more complex than necessary.
> A possible modularization is to move the internal model 
> (org.apache.syncope.core.persistence*) and the persistence impl 
> (org.apache.syncope.core.persistence.impl) out of core and into separate 
> modules.
> One big advantage would be that the jpa code enhancements would then run in 
> the model module only. Currently we run into some problems in the cxf 
> migration when running the rest itests in core that may be caused by eclipse 
> overwriting the enhanced classes with plain classes. If the model 
> (peristence) classes are in a separate module we could leave it out of 
> eclipse and so this would be no issue anymore.
> Another advantage would be that the persistence tests could run in the 
> persistence impl module so when working on the core they would not have to 
> run each time. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to