[
https://issues.apache.org/jira/browse/SYNCOPE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552524#comment-13552524
]
Francesco Chicchiriccò commented on SYNCOPE-241:
------------------------------------------------
Christian, the updated SYNCOPE-241-4.patch looks generally fine to me.
Some remarks:
1. Could you please remove commented entries in
core/src/test/resources/testpersistence.xml? I also find the name of this file
(given its purpose) quite confusing.
2. There is still some Activity (instead of Activiti) referenced in
ContentLoader
3. There are some FindBugs warnings about not being able to correctly clean up
InputStream in ContentLoader
4. (Not included in this patch but somewhere before) there are some redundant
"public abstract" in interface methods (AccountPolicyEnforcer, for example)
5. I don't like much the idea of adding interface / implementation
(UserSuspender / WorkflowUserSuspender) for a very specific non-functional need
like as in this case. As you pointed out, this is just used in
AccountPolicyEnforcerImpl, so why don't you just consolidate this in there?
6. Given the refactory for SpringContextInitializer, for uniformity purpose I
would rename WorkflowLoader to WorkflowInstanceLoader and WorkflowSetup to
WorkflowLoader (including loadWorkflowAdapters() to load())
Thanks.
> Move persistence and persistence impl into separate modules
> -----------------------------------------------------------
>
> Key: SYNCOPE-241
> URL: https://issues.apache.org/jira/browse/SYNCOPE-241
> Project: Syncope
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.0.3-incubating
> Reporter: Christian Schneider
> Fix For: 1.1.0
>
> Attachments: SYNCOPE-241-2.patch, SYNCOPE-241-3.patch,
> SYNCOPE-241-4.patch, SYNCOPE-241.patch
>
>
> The core module currently contains many parts of syncope. This makes it
> bigger and more complex than necessary.
> A possible modularization is to move the internal model
> (org.apache.syncope.core.persistence*) and the persistence impl
> (org.apache.syncope.core.persistence.impl) out of core and into separate
> modules.
> One big advantage would be that the jpa code enhancements would then run in
> the model module only. Currently we run into some problems in the cxf
> migration when running the rest itests in core that may be caused by eclipse
> overwriting the enhanced classes with plain classes. If the model
> (peristence) classes are in a separate module we could leave it out of
> eclipse and so this would be no issue anymore.
> Another advantage would be that the persistence tests could run in the
> persistence impl module so when working on the core they would not have to
> run each time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
