On 17/01/2013 15:37, Christian Schneider wrote:
I added the code to copy them too. I just committed them as they were
reported changed. Should I delete the files and tell svn to ignore them?
Just updated svn:ignore + removed again all local archetype resources
from SVN.
I will open an issue to change the resource population for archetype in
order to be more robust to this kind of changes.
I found that the AbstractDAOTests can not simply create the Activiti
properties as the table is not there when we omit the spring xml to
initialize Activiti. So I wanted to make the ContentLoader more flexible.
This way I was able to replace the xsl based removal of Activiti
properties by a java based one. I think this is better than xsl as it is
more obvious to see in the code. It took me a while to see that the xsl
does this...
Did you take into any account the export procedure for subsequent
re-import when changing this logic?
Have you tried how this behaves in overlays generated from the archetype?
Now we don't have any more a single content.xml (as generated by export
generates) but two separate content.xml and activiticontent.xml
I will open another issue to verify how export / import procedure will
work after these changes.
Regards.
On 17.01.2013 15:32, Francesco Chicchiriccò wrote:
On 17/01/2013 15:27, cschnei...@apache.org wrote:
Author: cschneider
Date: Thu Jan 17 14:27:33 2013
New Revision: 1434684
URL: http://svn.apache.org/viewvc?rev=1434684&view=rev
Log:
SYNCOPE-241 Adding new activiticontent.xml to archetype
Why this activiticontent.xml? Why removing the XSLT dynamic from core
pom.xml?
Moreover: please consider that archetype resources must be copied from
core and console as part of the build process and not statically
committed as you've just did for content.xml and activiticontent.xml.
Regards.
--
Dott. Francesco Chicchiriccò
Tel +393290573276
Amministratore unico @ Tirasa S.r.l.
Viale D'Annunzio 267 - 65127 Pescara
Tel +39 0859116307 / FAX +39 0859111173
http://www.tirasa.net
ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/
"To Iterate is Human, to Recurse, Divine"
(James O. Coplien, Bell Labs)
--
Francesco Chicchiriccò
ASF Member, Apache Syncope PMC chair, Apache Cocoon PMC Member
http://people.apache.org/~ilgrosso/
