Francesco Chicchiriccò created SYNCOPE-323:
----------------------------------------------

             Summary: REST: create turns into update for some entities
                 Key: SYNCOPE-323
                 URL: https://issues.apache.org/jira/browse/SYNCOPE-323
             Project: Syncope
          Issue Type: Bug
          Components: core
    Affects Versions: 1.0.5, 1.1.0
            Reporter: Francesco Chicchiriccò
            Assignee: Francesco Chicchiriccò
             Fix For: 1.1.0


I have recently found that some REST create requests are treated as update.

For example, try to create a new schema on the admin console and provide a name 
of another existing schema: you won't get any warning; only, the existing 
schema definition will be completely replaced by the newly inserted entry.

After some investigations, I've found that this happens for external resources, 
schema, derived schema and virtual schema.
Such entities have in common the fact that the JPA @Id is non-generated.
The way how saving is handled (via EntityManager#merge()) finally turns an 
expected create into an update.

I don't find such behavior as correct, hence I would propose to throw an 
exception, in the REST create methods for the entities named above, in case the 
key of the entity being created is already present. 

[1] http://markmail.org/message/kxrh7pgwuijwyfik

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to