[ https://issues.apache.org/jira/browse/SYNCOPE-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734476#comment-13734476 ]
Francesco Chicchiriccò commented on SYNCOPE-409: ------------------------------------------------ Hi Guido, your patch looks fine for the core, and I can confirm that all tests succeed. About console, however, I wouldn't touch SearchView since it is embedded in different places (Users>Search and Roles>Search but not only there): moreover, I would also go for the alternative you suggest above, e.g. make the "About" tab similar to "Recipients", with a checkbox toggling disabled / enabled the search form below: [ ] All users (it: "Tutti gli utenti", pt_BR: Google translate or ask [~bera]) {search form enabled or disabled depending on whether the checkbox above is flagged or not} This will also solve the problem of changing SearchView. Thanks for your contribution! > Allow notifications with empty about field > ------------------------------------------ > > Key: SYNCOPE-409 > URL: https://issues.apache.org/jira/browse/SYNCOPE-409 > Project: Syncope > Issue Type: Improvement > Components: console, core > Affects Versions: 1.1.3 > Reporter: Guido Wimmel > Assignee: Francesco Chicchiriccò > Priority: Minor > Fix For: 1.1.4, 1.2.0 > > Attachments: syncopeNotificationsEmptyAbout.patch > > > Currently, when one creates a new notification in Syncope, one is forced to > enter a user search condition in the "About" tab that allows to restrict the > notifications to specific users. IMO this is not always necessary - it should > also be possible to leave the field empty such that the notification is sent > for all users. > Allowing the Notification.about field to be empty would also improve > performance in this case, as an unnecessary search query to the database can > be avoided. This is especially relevant for MySQL, as we observed full table > scan behaviour for queries executed by AttributableSearchDAOImpl.matches() > (called by NotificationManager) for even very simple search conditions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira