[
https://issues.apache.org/jira/browse/SYNCOPE-460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guido Wimmel updated SYNCOPE-460:
---------------------------------
Attachment: syncope-460_20121220.patch
Here's a revised patch. It took me a bit longer than expected, as I stumbled
upon a problem similar to SYNCOPE-232, thus I had to remove the
IsolationLevelDataSourceAdapter around the BasicDataSource as well. The
isolation level is now set on BasicDataSource directly.
Most properties of BasicDataSource are configurable via persistence.properties,
with fallback to the default values DBCP uses currently. I only left out a few
properties I think should not be configurable or have no reasonable default.
I could only test with H2 and MySQL, by running the full build including the
integration tests. On my system, the tests also run successfully with
transaction levels REPEATABLE_READ, SERIALIZABLE, and READ_UNCOMITTED, but
probably some more testing would be advisable here.
> Default datasource uses BasicDataSource
> ---------------------------------------
>
> Key: SYNCOPE-460
> URL: https://issues.apache.org/jira/browse/SYNCOPE-460
> Project: Syncope
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.1.5
> Reporter: Oliver Wulff
> Priority: Minor
> Fix For: 1.1.6, 1.2.0
>
> Attachments: patch.git, syncope-460_20121220.patch
>
>
> Replace org.springframework.jdbc.datasource.DriverManagerDataSource by
> org.apache.commons.dbcp.BasicDataSource as recommended by spring:
> http://docs.spring.io/spring/docs/current/spring-framework-reference/html/jdbc.html#jdbc-connections
> Make property "isolationLevelName" configurable in persistence.properties
> with default ISOLATION_READ_COMMITTED
> See full discussion in dev@ ML: http://markmail.org/message/33aheawb5irzl3xc
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
