[ https://issues.apache.org/jira/browse/SYNCOPE-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029194#comment-14029194 ]
Colm O hEigeartaigh commented on SYNCOPE-313: --------------------------------------------- Hi Francesco, > any particular reason why not to replace SHA1("SHA-1", false) with > SHA("SHA-1", false)? I just left SHA1 there for backwards compatibility reasons, so that a value of "SHA1" as part of the password cipher algorithm would still work. I don't see any harm in having both SHA + SHA1 map to the same thing. > the last argument in SyncopeUser#setEncodedPassword looks not-needed: correct? Yep. What do you think about backporting the SyncopeUser + CipherAlgorithm changes (just the SHA addition) to 1.1.x? At least then a user could plug in their own SyncActions implementation to support this behaviour if required. Colm. > Support synchronizing non-cleartext passwords from external resources > --------------------------------------------------------------------- > > Key: SYNCOPE-313 > URL: https://issues.apache.org/jira/browse/SYNCOPE-313 > Project: Syncope > Issue Type: Improvement > Reporter: Colm O hEigeartaigh > Assignee: Colm O hEigeartaigh > Fix For: 1.2.0 > > > Currently we can synchronize cleartext passwords from external resources. > However, we can't handle non-cleartext passwords, as they get treated as if > they are plaintext passwords when imported into Syncope, and hence hashed > again according to user.cipherAlgorithm(). > This task is to treat an imported password as hashed according to a give > cipher algorithm configured on the connector (for example via 'Password > Cipher Algorithm' for the DB Connector). > This is specific to each individual connector, as for example for the DB > Connector, it might just be a hashed value stored in a table, whereas for > LDAP it'll be of the form "CIPHER}VALUE" etc. > Note that we we cannot refer to any specific connector bundle from inside the > SyncopeSyncResultHandler, hence we should find the cleanest place to > encapsulate the following logic: > if (password.isClearText()) { > // do as currently done > } else { > if (connector.isLDAP()) { > // extract cipher and value > } else if (connector.isDBTable()) { > // treat value as ciphered with the cipher defined in connector > configuration > } else { > ... > } > } -- This message was sent by Atlassian JIRA (v6.2#6252)